Docserver: Make MockFileSystem not iterate over the entire file system as part

Docserver: Make MockFileSystem not iterate over the entire file system as part
of its operation. It was basically working around a TestFileSystem bug, so fix
that too. This will make running tests much faster, particularly now that the
entire of the src/ directory is considered part of the docset.

BUG=None
R=yoz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248838

[not at google - send to devlin, 2014-02-04 00:18:24]

P.S. i've also sent you a couple of other docserver patches.

[Yoyo Zhou, 2014-02-05 00:32:33]

LGTM

https://codereview.chromium.org/151883009/diff/50001/chrome/common/extensions...
File chrome/common/extensions/docs/server2/test_file_system.py (right):

https://codereview.chromium.org/151883009/diff/50001/chrome/common/extensions...
chrome/common/extensions/docs/server2/test_file_system.py:44: # Support
non-canonical paths until the server has purged all
Sounds like there's a TODO in here.

https://codereview.chromium.org/151883009/diff/50001/chrome/common/extensions...
chrome/common/extensions/docs/server2/test_file_system.py:52: result['/' + path]
= result[path]
nit: this is written differently from the above

https://codereview.chromium.org/151883009/diff/50001/chrome/common/extensions...
chrome/common/extensions/docs/server2/test_file_system.py:76: if path == '' or
path.endswith('/'):
path_util.IsDirectory

[not at google - send to devlin, 2014-02-05 03:55:53]

ok so that path.IsDirectory comment opened up a bit of a can of worms in the
end, but I got there eventually (fixing stray leading /s basically).

https://codereview.chromium.org/151883009/diff/50001/chrome/common/extensions...
File chrome/common/extensions/docs/server2/test_file_system.py (right):

https://codereview.chromium.org/151883009/diff/50001/chrome/common/extensions...
chrome/common/extensions/docs/server2/test_file_system.py:44: # Support
non-canonical paths until the server has purged all
On 2014/02/05 00:32:33, Yoyo Zhou wrote:
> Sounds like there's a TODO in here.

Done.

https://codereview.chromium.org/151883009/diff/50001/chrome/common/extensions...
chrome/common/extensions/docs/server2/test_file_system.py:52: result['/' + path]
= result[path]
On 2014/02/05 00:32:33, Yoyo Zhou wrote:
> nit: this is written differently from the above

Done.

https://codereview.chromium.org/151883009/diff/50001/chrome/common/extensions...
chrome/common/extensions/docs/server2/test_file_system.py:76: if path == '' or
path.endswith('/'):
On 2014/02/05 00:32:33, Yoyo Zhou wrote:
> path_util.IsDirectory

Ah! Yeah so I did this and in fact it mooted the TODOs above since it required
me to actually enforce that path restriction after all. So I could delete a few
of the tests.

[not at google - send to devlin, 2014-02-05 04:02:19]

Committed patchset #3 manually as r248838 (presubmit successful).