Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1518823002: Use volatile to prevent heap-to-stack promotion in an ASan test (Closed)

Created:
5 years ago by Reid Kleckner
Modified:
5 years ago
Reviewers:
jschuh, Nico
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use volatile to prevent heap-to-stack promotion in an ASan test BUG=568610 TBR=thakis@chromium.org,jschuh@chromium.org Committed: https://crrev.com/4a36e67ea9694e6c01a3df6a1f6b967453c506c2 Cr-Commit-Position: refs/heads/master@{#364443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sandbox/win/src/address_sanitizer_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Reid Kleckner
5 years ago (2015-12-10 19:20:01 UTC) #1
Nico
lgtm, thanks
5 years ago (2015-12-10 19:20:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518823002/1
5 years ago (2015-12-10 19:20:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 19:54:30 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-10 19:56:08 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4a36e67ea9694e6c01a3df6a1f6b967453c506c2
Cr-Commit-Position: refs/heads/master@{#364443}

Powered by Google App Engine
This is Rietveld 408576698