Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 1518803004: Add unsized color-renderable formats to getInternalformatParameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
index 129af538a8c6dc91515c8c99a0fbcb49a0aed0ca..09620428310d670519d3ebf4aa5787d0628071db 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
@@ -327,6 +327,11 @@ ScriptValue WebGL2RenderingContextBase::getInternalformatParameter(ScriptState*
bool floatType = false;
switch (internalformat) {
+ // Renderbuffer doesn't support unsized internal formats,
+ // though GL_RGB and GL_RGBA are color-renderable.
+ case GL_RGB:
+ case GL_RGBA:
+ // Multisampling is not supported for signed and unsigned integer internal formats.
case GL_R8UI:
case GL_R8I:
case GL_R16UI:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698