Improve GL bindings for Ganesh surfaces.

Improve GL bindings for Ganesh surfaces.

Add support for binding a Ganesh surface directly to a framebuffer.

Refactored the code to make it easier to distinguish binding a Ganesh
surface to a texture from binding to a framebuffer.

Switch to using std::unique_ptr<> and update example code.  Note that
these examples will see further changes shortly which will eliminate
the excess scoped_ptr / unique_ptr conversions among other things.

BUG=
R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/c515f59d4b83c6ce53e3c78ed71c7b28733eb824

[jeffbrown, 2015-12-10 22:15:06]

jeffbrown@google.com changed reviewers:
+ abarth@google.com

[viettrungluu, 2015-12-10 22:43:52]

viettrungluu@chromium.org changed reviewers:
+ viettrungluu@chromium.org

[viettrungluu, 2015-12-10 22:43:52]

No tests? :(

[abarth-chromium, 2015-12-10 22:46:10]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org
- viettrungluu@chromium.org

[abarth-chromium, 2015-12-10 22:46:11]

LGTM

https://codereview.chromium.org/1518793004/diff/1/mojo/skia/ganesh_framebuffe...
File mojo/skia/ganesh_framebuffer_surface.h (right):

https://codereview.chromium.org/1518793004/diff/1/mojo/skia/ganesh_framebuffe...
mojo/skia/ganesh_framebuffer_surface.h:24:
GaneshFramebufferSurface(GaneshContext* context);
Please mark one-argument constructors explicit

https://codereview.chromium.org/1518793004/diff/1/mojo/skia/ganesh_texture_su...
File mojo/skia/ganesh_texture_surface.h (right):

https://codereview.chromium.org/1518793004/diff/1/mojo/skia/ganesh_texture_su...
mojo/skia/ganesh_texture_surface.h:24: std::unique_ptr<GLTexture>&& texture);
No need for && here

[jeffbrown, 2015-12-12 01:37:02]

https://codereview.chromium.org/1518793004/diff/1/mojo/skia/ganesh_framebuffe...
File mojo/skia/ganesh_framebuffer_surface.h (right):

https://codereview.chromium.org/1518793004/diff/1/mojo/skia/ganesh_framebuffe...
mojo/skia/ganesh_framebuffer_surface.h:24:
GaneshFramebufferSurface(GaneshContext* context);
On 2015/12/10 22:46:11, abarth-chromium wrote:
> Please mark one-argument constructors explicit

Done.

https://codereview.chromium.org/1518793004/diff/1/mojo/skia/ganesh_texture_su...
File mojo/skia/ganesh_texture_surface.h (right):

https://codereview.chromium.org/1518793004/diff/1/mojo/skia/ganesh_texture_su...
mojo/skia/ganesh_texture_surface.h:24: std::unique_ptr<GLTexture>&& texture);
On 2015/12/10 22:46:11, abarth-chromium wrote:
> No need for && here

Done.

[jeffbrown, 2015-12-14 21:28:57]

Description was changed from

==========
Improve GL bindings for Ganesh surfaces.

Add support for binding a Ganesh surface directly to a framebuffer.

Refactored the code to make it easier to distinguish binding a Ganesh
surface to a texture from binding to a framebuffer.

Switch to using std::unique_ptr<> and update example code.  Note that
these examples will see further changes shortly which will eliminate
the excess scoped_ptr / unique_ptr conversions among other things.

BUG=
==========

to

==========
Improve GL bindings for Ganesh surfaces.

Add support for binding a Ganesh surface directly to a framebuffer.

Refactored the code to make it easier to distinguish binding a Ganesh
surface to a texture from binding to a framebuffer.

Switch to using std::unique_ptr<> and update example code.  Note that
these examples will see further changes shortly which will eliminate
the excess scoped_ptr / unique_ptr conversions among other things.

BUG=
R=abarth@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/c515f59d4b83c6ce53e3c78ed71...
==========

[jeffbrown, 2015-12-14 21:29:06]

Committed patchset #2 (id:20001) manually as
c515f59d4b83c6ce53e3c78ed71c7b28733eb824 (presubmit successful).