Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1518793002: Revert of Remove clearing of pending invalidation sets. (Closed)

Created:
5 years ago by wkorman
Modified:
5 years ago
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove clearing of pending invalidation sets. (patchset #2 id:20001 of https://codereview.chromium.org/1507653002/ ) Reason for revert: Suspect root cause of crash in blink::StyleInvalidator::pushInvalidationSetsForElement http://crbug.com/568502 Original issue's description: > Remove clearing of pending invalidation sets. > > In preparation for making SubtreeStyleChange not affect the sibling > forest. > > We can skip scheduling descendant invalidation sets for elements whose > styleChangeType is SubtreeStyleChange. However, with sibling invalidation > sets, we still need to schedule invalidations for invalidating the > sibling forest when we change SubtreeStyleChange to be a strict subtree > recalc. > > We may not clear pending invalidations on detach either, unless the node > was actually removed from the dom tree, since there might be pending > sibling invalidations. > > R=dstockwell@chromium.org,ericwilligers@chromium.org > BUG=557440 > > Committed: https://crrev.com/c0735df3d8f8efa24af168a6e8d5c02a7be0641c > Cr-Commit-Position: refs/heads/master@{#364064} TBR=dstockwell@chromium.org,ericwilligers@chromium.org,rune@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=557440 Committed: https://crrev.com/91a8470f2902978d9fbdc6de3618f6f7d374c014 Cr-Commit-Position: refs/heads/master@{#364416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp View 1 chunk +15 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
wkorman
Created Revert of Remove clearing of pending invalidation sets.
5 years ago (2015-12-10 18:56:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518793002/1
5 years ago (2015-12-10 18:57:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 18:59:36 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-10 19:00:54 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91a8470f2902978d9fbdc6de3618f6f7d374c014
Cr-Commit-Position: refs/heads/master@{#364416}

Powered by Google App Engine
This is Rietveld 408576698