Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: include/codec/SkCodec.h

Issue 1518743002: Add reallyHasAlpha() to SkAndroidCodec (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Change comment on onReallyHasAlpha Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/codec/SkAndroidCodec.h ('k') | src/codec/SkAndroidCodec.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/codec/SkCodec.h
diff --git a/include/codec/SkCodec.h b/include/codec/SkCodec.h
index 67ccdb241c3225e35e09ef2b75d1fd60bbd64a6b..d06c2c3399e4858e30626945948f4933f5d059c6 100644
--- a/include/codec/SkCodec.h
+++ b/include/codec/SkCodec.h
@@ -286,7 +286,7 @@ public:
* FIXME: see skbug.com/3582.
*/
bool reallyHasAlpha() const {
- return this->onReallyHasAlpha();
+ return kOpaque_SkAlphaType != this->getInfo().alphaType() && this->onReallyHasAlpha();
}
/**
@@ -486,7 +486,15 @@ protected:
return false;
}
- virtual bool onReallyHasAlpha() const { return false; }
+ /**
+ * This is only called if the image indicates that it is not opaque.
+ * By default we will assume that the image is in fact non-opaque.
+ * Subclasses may override this function if they intend to verify
+ * that the image actually has alpha.
+ */
+ virtual bool onReallyHasAlpha() const {
+ return true;
+ }
/**
* If the stream was previously read, attempt to rewind.
« no previous file with comments | « include/codec/SkAndroidCodec.h ('k') | src/codec/SkAndroidCodec.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698