Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 151873002: Reduce the height of the feedback page. (Closed)

Created:
6 years, 10 months ago by rkc
Modified:
6 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Reduce the height of the feedback page. The current height of the feedback page is causing the bottom of the page to get pushed off the boundary on certain screen sizes. The problem is now worse on other platforms due to the System Information link also being available there. Decrease some of the unnecessary padding on the feedback page to make sure it fits on the screens of machines with smaller displays. R=xiyuan@chromium.org BUG=334235 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/resources/feedback/css/feedback.css View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/feedback/js/event_handler.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/feedback/js/feedback.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
rkc
6 years, 10 months ago (2014-02-01 00:21:56 UTC) #1
xiyuan
lgtm
6 years, 10 months ago (2014-02-01 04:52:50 UTC) #2
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 10 months ago (2014-02-03 20:40:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/151873002/1
6 years, 10 months ago (2014-02-03 20:40:43 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 22:43:49 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=255819
6 years, 10 months ago (2014-02-03 22:43:50 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 22:43:57 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 22:43:57 UTC) #8
rkc
6 years, 10 months ago (2014-02-03 22:46:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r248598 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698