Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1518713004: Make telemetry_gpu_test isolate a copy of telemetry_gpu_new_test. (Closed)

Created:
5 years ago by Ken Russell (switch to Gerrit)
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make telemetry_gpu_test isolate a copy of telemetry_gpu_new_test. Once this lands, the recipe will be switched back to run the telemetry_gpu_test target, and telemetry_gpu_new_test will be removed. BUG=561863 TBR=phajdan.jr@chromium.org Committed: https://crrev.com/d454228bc08c2f2f7c6b430a5c39b571a530936c Cr-Commit-Position: refs/heads/master@{#364592}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -24 lines) Patch
M chrome/telemetry_gpu_test.isolate View 2 chunks +7 lines, -23 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 25 (11 generated)
Ken Russell (switch to Gerrit)
PTAL
5 years ago (2015-12-10 21:25:30 UTC) #2
Ken Russell (switch to Gerrit)
+vadimsh as another isolate OWNER
5 years ago (2015-12-10 21:27:15 UTC) #4
Vadim Sh.
lgtm if it works
5 years ago (2015-12-10 21:40:31 UTC) #5
Ken Russell (switch to Gerrit)
On 2015/12/10 21:40:31, Vadim Sh. wrote: > lgtm if it works Built and tested via ...
5 years ago (2015-12-10 22:11:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518713004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518713004/1
5 years ago (2015-12-10 22:12:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/127787)
5 years ago (2015-12-10 22:25:32 UTC) #10
Dirk Pranke
lgtm
5 years ago (2015-12-10 22:27:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518713004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518713004/1
5 years ago (2015-12-10 22:29:55 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/127798)
5 years ago (2015-12-10 22:42:25 UTC) #15
Ken Russell (switch to Gerrit)
TBR'ing to phajdan.jr.
5 years ago (2015-12-10 23:37:36 UTC) #17
Ken Russell (switch to Gerrit)
5 years ago (2015-12-10 23:37:50 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518713004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518713004/1
5 years ago (2015-12-10 23:38:52 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 02:29:51 UTC) #23
commit-bot: I haz the power
5 years ago (2015-12-11 02:30:51 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d454228bc08c2f2f7c6b430a5c39b571a530936c
Cr-Commit-Position: refs/heads/master@{#364592}

Powered by Google App Engine
This is Rietveld 408576698