Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1518703002: Re-re-land FastAccessorBuilder. (Closed)

Created:
5 years ago by vogelheim
Modified:
5 years ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-re-land FastAccessorBuilder. ... using the RawMachineAssembler and the work in crrev.com/1407313004. The original change collided with crrev.com/1513543003. BUG=chromium:508898 LOG=Y Committed: https://crrev.com/515d9ccd8e6df7bf2ca01e2a55aaad30226399e1 Cr-Commit-Position: refs/heads/master@{#32742} patch from issue 1474543004 at patchset 260001 (http://crrev.com/1474543004#ps260001) Committed: https://crrev.com/ee5c38d7db907ff86dd4049721c0cb4bc90a6c4d Cr-Commit-Position: refs/heads/master@{#32753} patch from issue 1504713012 at patchset 20001 (http://crrev.com/1504713012#ps20001) Committed: https://crrev.com/5819e4be5bd128556b0d735abe6b58173da67079 Cr-Commit-Position: refs/heads/master@{#32786}

Patch Set 1 : Reverted patch-set, as reviewed in crrev.com/1504713012#ps20001) #

Patch Set 2 : Adapt test-api-accessors to new API. Also enable it for reals. #

Patch Set 3 : Add test restrictions, as for test-api-fast-accessor-builder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+876 lines, -44 lines) Patch
M BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
M include/v8.h View 3 chunks +9 lines, -4 lines 0 comments Download
A include/v8-experimental.h View 1 chunk +53 lines, -0 lines 0 comments Download
M src/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M src/api.cc View 6 chunks +16 lines, -13 lines 0 comments Download
A src/api-experimental.h View 1 chunk +28 lines, -0 lines 0 comments Download
A src/api-experimental.cc View 1 chunk +126 lines, -0 lines 0 comments Download
A src/compiler/fast-accessor-assembler.h View 1 chunk +106 lines, -0 lines 0 comments Download
A src/compiler/fast-accessor-assembler.cc View 1 chunk +223 lines, -0 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/test-api-accessors.cc View 1 2 2 chunks +20 lines, -24 lines 0 comments Download
A test/cctest/test-api-fast-accessor-builder.cc View 1 chunk +274 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
vogelheim
Oh hai again, please have a look. :-/ When the test was written, the idea ...
5 years ago (2015-12-10 15:07:54 UTC) #2
Michael Starzinger
LGTM.
5 years ago (2015-12-10 15:10:58 UTC) #3
epertoso
lgtm
5 years ago (2015-12-10 15:22:08 UTC) #4
epertoso
On 2015/12/10 at 15:22:08, epertoso wrote: > lgtm But, of course, test-api-accessors.cc should be updated.
5 years ago (2015-12-10 15:22:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518703002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518703002/40001
5 years ago (2015-12-11 09:40:10 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-11 09:53:55 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-11 09:54:05 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5819e4be5bd128556b0d735abe6b58173da67079
Cr-Commit-Position: refs/heads/master@{#32786}

Powered by Google App Engine
This is Rietveld 408576698