Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Unified Diff: tools/gn/target.h

Issue 1518663003: Make GN public configs apply libs to targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/target.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target.h
diff --git a/tools/gn/target.h b/tools/gn/target.h
index 10d3b05dd992ed1be07bb2a0a02248f4205b9793..eff85e84172214e9709780540b233dcf537ea90e 100644
--- a/tools/gn/target.h
+++ b/tools/gn/target.h
@@ -249,13 +249,10 @@ class Target : public Item {
// Pulls necessary information from dependencies to this one when all
// dependencies have been resolved.
- void PullDependentTarget(const Target* dep, bool is_public);
- void PullDependentTargets();
-
- // These each pull specific things from dependencies to this one when all
- // deps have been resolved.
- void PullPublicConfigs();
- void PullPublicConfigsFrom(const Target* from);
+ void PullDependentTargetConfigsFrom(const Target* dep);
+ void PullDependentTargetConfigs();
+ void PullDependentTargetLibsFrom(const Target* dep, bool is_public);
+ void PullDependentTargetLibs();
void PullRecursiveHardDeps();
// Fills the link and dependency output files when a target is resolved.
@@ -289,6 +286,7 @@ class Target : public Item {
LabelTargetVector public_deps_;
LabelTargetVector data_deps_;
+ // See getters for more info.
UniqueVector<LabelConfigPair> configs_;
UniqueVector<LabelConfigPair> all_dependent_configs_;
UniqueVector<LabelConfigPair> public_configs_;
« no previous file with comments | « no previous file | tools/gn/target.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698