Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1518663003: Make GN public configs apply libs to targets. (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
Patrick Monette
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make GN public configs apply libs to targets. Previously, putting libs or lib_dirs in a config that a target exports as a public config would not result in those values getting applied to dependant targets. This patch applies those to the targets how one would expect by resolving the public configs before the libs are copied. This involved splitting up pulling dependencies' information into a configs phase (which must happen before we update the libs on the target) and the libs phase (which must happen after so the dependencies' libs come after). Clarify ordering in the help. Committed: https://crrev.com/567cb68891e32e2a398302b2b2405e4250ccc1d7 Cr-Commit-Position: refs/heads/master@{#364749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -25 lines) Patch
M tools/gn/target.h View 2 chunks +5 lines, -7 lines 0 comments Download
M tools/gn/target.cc View 3 chunks +33 lines, -18 lines 0 comments Download
M tools/gn/target_unittest.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/gn/variables.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (7 generated)
brettw
5 years ago (2015-12-11 00:33:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518663003/1
5 years ago (2015-12-11 00:37:04 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/25838)
5 years ago (2015-12-11 00:50:07 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518663003/1
5 years ago (2015-12-11 03:33:54 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-11 03:48:54 UTC) #10
Patrick Monette
lgtm
5 years ago (2015-12-11 17:31:04 UTC) #11
Patrick Monette
lgtm lgtm
5 years ago (2015-12-11 17:31:06 UTC) #12
Patrick Monette
lgtm lgtm lgtm
5 years ago (2015-12-11 17:31:06 UTC) #13
Patrick Monette
lgtm lgtm lgtm lgtm
5 years ago (2015-12-11 17:31:06 UTC) #14
Patrick Monette
lgtm lgtm lgtm lgtm lgtm
5 years ago (2015-12-11 17:31:06 UTC) #15
Patrick Monette
lgtm lgtm lgtm lgtm lgtm lgtm
5 years ago (2015-12-11 17:31:09 UTC) #16
Patrick Monette
lgtm
5 years ago (2015-12-11 17:31:13 UTC) #17
Patrick Monette
lgtm
5 years ago (2015-12-11 17:31:13 UTC) #18
Patrick Monette
On 2015/12/11 17:31:13, Patrick Monette wrote: > lgtm Sorry I just learned what quick lgtm ...
5 years ago (2015-12-11 17:31:46 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518663003/1
5 years ago (2015-12-11 18:19:23 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 18:38:35 UTC) #22
commit-bot: I haz the power
5 years ago (2015-12-11 18:40:24 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/567cb68891e32e2a398302b2b2405e4250ccc1d7
Cr-Commit-Position: refs/heads/master@{#364749}

Powered by Google App Engine
This is Rietveld 408576698