Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1518643004:
Update permissions blacklist. (Closed)
|
Created:
5 years ago by newt (away) Modified:
5 years ago CC:
chromium-reviews, cbentzel+watch_chromium.org, mikecase+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate permissions blacklist.
android.permission.AUTHENTICATE_ACCOUNTS can't be granted on M+ devices
since it's been removed from Android.
Committed: https://crrev.com/8fbc1252ce8a7322e01c1fa723d52640c82f32d7
Cr-Commit-Position: refs/heads/master@{#365400}
Patch Set 1 #Patch Set 2 : added android.permission.AUTHENTICATE_ACCOUNTS to permissions blacklist #Messages
Total messages: 23 (10 generated)
newt@chromium.org changed reviewers: + aberent@chromium.org, dgn@chromium.org
PTAL. Why does this permission exist in the first place? Is it needed on pre-M devices?
The CQ bit was checked by newt@chromium.org to run a CQ dry run
The CQ bit was unchecked by newt@chromium.org
The CQ bit was checked by newt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518643004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
Alternatively, if this permission is needed on pre-M devices, I could add maxSdkVersion="22" to the <uses-permission> element. http://developer.android.com/guide/topics/manifest/uses-permission-element.ht...
On 2015/12/10 23:17:37, newt wrote: > Alternatively, if this permission is needed on pre-M devices, I could add > maxSdkVersion="22" to the <uses-permission> element. > > http://developer.android.com/guide/topics/manifest/uses-permission-element.ht... Yes, it is needed for the tests on pre-M devices. The reason is that the tests need to create a dummy SPNEGO test account using the AccountManager. See DummySpnegoAuthenticator.ensureTestAccountExists().
How do you get this error? I use the SpnegoAuthenticator APK on M and never saw it. Do I need to enable some strict mode or something like that? maxSdkVersion seems like the appropriate fix yes.
On 2015/12/11 10:33:41, dgn wrote: > How do you get this error? I use the SpnegoAuthenticator APK on M and never saw > it. Do I need to enable some strict mode or something like that? maxSdkVersion > seems like the appropriate fix yes. I saw the error in the CL message when running net_unittests (out/Debug/bin/run_net_unittests) on an M device (Nexus 5X). If you're installing the SpnegoAuthenticator APK, you'll presumably see the same message in the logcat during installation.
Description was changed from
==========
Remove ungrantable permission android.permission.AUTHENTICATE_ACCOUNTS.
This permission results in an error when installing the net unittests APK
and the SpnegoAuthenticator APK:
Possible problem when granting permissions. Blacklist may need to be updated.
Operation not allowed: java.lang.SecurityException: Permission
android.permission.
This permission apparently can't be granted, so there's no need for it.
==========
to
==========
Update permissions blacklist.
android.permission.AUTHENTICATE_ACCOUNTS can't be granted on M+ devices
since it's been removed from Android.
==========
On 2015/12/11 22:58:41, newt wrote: > On 2015/12/11 10:33:41, dgn wrote: > > How do you get this error? I use the SpnegoAuthenticator APK on M and never > saw > > it. Do I need to enable some strict mode or something like that? maxSdkVersion > > seems like the appropriate fix yes. > > I saw the error in the CL message when running net_unittests > (out/Debug/bin/run_net_unittests) on an M device (Nexus 5X). If you're > installing the SpnegoAuthenticator APK, you'll presumably see the same message > in the logcat during installation. Ah. Looks like this is an issue with the test runner scripts, which try to grant android.permission.AUTHENTICATE_ACCOUNTS and fail. device_utils.py needs to be updated; not the AndroidManifest.xml files.
newt@chromium.org changed reviewers: + rnephew@chromium.org
rnephew: PTAL
On 2015/12/15 22:09:52, newt wrote: > rnephew: PTAL lgtm
The CQ bit was checked by newt@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518643004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518643004/20001
Message was sent while issue was closed.
Description was changed from ========== Update permissions blacklist. android.permission.AUTHENTICATE_ACCOUNTS can't be granted on M+ devices since it's been removed from Android. ========== to ========== Update permissions blacklist. android.permission.AUTHENTICATE_ACCOUNTS can't be granted on M+ devices since it's been removed from Android. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Update permissions blacklist. android.permission.AUTHENTICATE_ACCOUNTS can't be granted on M+ devices since it's been removed from Android. ========== to ========== Update permissions blacklist. android.permission.AUTHENTICATE_ACCOUNTS can't be granted on M+ devices since it's been removed from Android. Committed: https://crrev.com/8fbc1252ce8a7322e01c1fa723d52640c82f32d7 Cr-Commit-Position: refs/heads/master@{#365400} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8fbc1252ce8a7322e01c1fa723d52640c82f32d7 Cr-Commit-Position: refs/heads/master@{#365400} |
