Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1518643003:
Roll third_party/freetype-android/src to VER-2-6-2. (Closed)
|
Created:
5 years ago by bungeman-chromium Modified:
5 years ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll third_party/freetype-android/src to VER-2-6-2.
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/30fe5e762e06261..66cf29b1bc869b
This updates from VER-2-6-1 + 1 to VER-2-6-2.
It is expected that this will change the weight of CFF fonts.
If this becomes undesireable, there is a patch which can be applied.
BUG=chromium:551028
Committed: https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f
Cr-Commit-Position: refs/heads/master@{#364438}
Committed: https://crrev.com/89e75f4d6c033ba5904cc808feb1292e8f211120
Cr-Commit-Position: refs/heads/master@{#364723}
Committed: https://crrev.com/d7a2a013501967e6762c0028697e1eab758e711e
Cr-Commit-Position: refs/heads/master@{#364850}
Patch Set 1 #Patch Set 2 : Add TestExpectations changes. #Patch Set 3 : Use NeedsManualRebaseline to avoid build misattribution by rebaseline-bot. #
Messages
Total messages: 37 (18 generated)
The CQ bit was checked by bungeman@chromium.org to run a CQ dry run
bungeman@chromium.org changed reviewers: + jshin@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518643003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bungeman@chromium.org changed reviewers: + wangxianzhu@chromium.org
The CQ bit was checked by wangxianzhu@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518643003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll third_party/freetype-android/src to VER-2-6-2. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log... This updates from VER-2-6-1 + 1 to VER-2-6-2. It is expected that this will change the weight of CFF fonts. If this becomes undesireable, there is a patch which can be applied. BUG=chromium:551028 ========== to ========== Roll third_party/freetype-android/src to VER-2-6-2. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log... This updates from VER-2-6-1 + 1 to VER-2-6-2. It is expected that this will change the weight of CFF fonts. If this becomes undesireable, there is a patch which can be applied. BUG=chromium:551028 Committed: https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f Cr-Commit-Position: refs/heads/master@{#364438} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f Cr-Commit-Position: refs/heads/master@{#364438}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1511413009/ by johnme@chromium.org. The reason for reverting is: This caused the following layout tests to fail flakily with very minor font rendering changes: css1/classification/list_style.html svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg css1/formatting_model/horizontal_formatting.html css1/formatting_model/canvas.html css1/cascade/important.html css1/font_properties/font_style.html css1/font_properties/font_variant.html css1/color_and_background/background_color.html css1/classification/list_style_position.html svg/batik/text/textAnchor3.svg fast/text/chromium-linux-fontconfig-renderstyle.html svg/canvas/canvas-pattern-svg.html css1/color_and_background/color.html fast/hidpi/clip-text-in-hidpi.html editing/caret/caret-color.html css1/classification/list_style_image.html css1/text_properties/text_align.html fast/invalid/009.html fast/compact/002.html First failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28N... Test output, including pixel diffs: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Android__... Normally we could just rebaseline the layout tests, but this is complicated by the fact that the failures are flaky. Specifically, all the tests failed in every build from 42280 until 42296 (the most recent one), except for builds 42282, 42284 and 42286 in which all the tests passed!.
Message was sent while issue was closed.
On 2015/12/11 11:30:09, johnme wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/1511413009/ by mailto:johnme@chromium.org. > > The reason for reverting is: This caused the following layout tests to fail > flakily with very minor font rendering changes: > > css1/classification/list_style.html > svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg > css1/formatting_model/horizontal_formatting.html > css1/formatting_model/canvas.html > css1/cascade/important.html > css1/font_properties/font_style.html > css1/font_properties/font_variant.html > css1/color_and_background/background_color.html > css1/classification/list_style_position.html > svg/batik/text/textAnchor3.svg > fast/text/chromium-linux-fontconfig-renderstyle.html > svg/canvas/canvas-pattern-svg.html > css1/color_and_background/color.html > fast/hidpi/clip-text-in-hidpi.html > editing/caret/caret-color.html > css1/classification/list_style_image.html > css1/text_properties/text_align.html > fast/invalid/009.html > fast/compact/002.html > > First failure: > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28N... > > Test output, including pixel diffs: > https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Android__... > > Normally we could just rebaseline the layout tests, but this is complicated by > the fact that the failures are flaky. Specifically, all the tests failed in > every build from 42280 until 42296 (the most recent one), except for builds > 42282, 42284 and 42286 in which all the tests passed!. Upon inspection, the reason why builds 42282, 42284 and 42286 'passed' was because they *did not* run *any* of the layout tests. If they had, I'm sure they would have produced identical results. I'll try a new roll with some [ NeedsRebaseline ]. Fortunately, this doesn't appear to actually be flaky. I'll update this with some [NeedsRebaseline] based on the result of the previous runs.
Message was sent while issue was closed.
Description was changed from ========== Roll third_party/freetype-android/src to VER-2-6-2. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log... This updates from VER-2-6-1 + 1 to VER-2-6-2. It is expected that this will change the weight of CFF fonts. If this becomes undesireable, there is a patch which can be applied. BUG=chromium:551028 Committed: https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f Cr-Commit-Position: refs/heads/master@{#364438} ========== to ========== Roll third_party/freetype-android/src to VER-2-6-2. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log... This updates from VER-2-6-1 + 1 to VER-2-6-2. It is expected that this will change the weight of CFF fonts. If this becomes undesireable, there is a patch which can be applied. BUG=chromium:551028 Committed: https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f Cr-Commit-Position: refs/heads/master@{#364438} ==========
The CQ bit was checked by bungeman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wangxianzhu@chromium.org Link to the patchset: https://codereview.chromium.org/1518643003/#ps20001 (title: "Add TestExpectations changes.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518643003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518643003/20001
Message was sent while issue was closed.
Description was changed from ========== Roll third_party/freetype-android/src to VER-2-6-2. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log... This updates from VER-2-6-1 + 1 to VER-2-6-2. It is expected that this will change the weight of CFF fonts. If this becomes undesireable, there is a patch which can be applied. BUG=chromium:551028 Committed: https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f Cr-Commit-Position: refs/heads/master@{#364438} ========== to ========== Roll third_party/freetype-android/src to VER-2-6-2. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log... This updates from VER-2-6-1 + 1 to VER-2-6-2. It is expected that this will change the weight of CFF fonts. If this becomes undesireable, there is a patch which can be applied. BUG=chromium:551028 Committed: https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f Cr-Commit-Position: refs/heads/master@{#364438} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Roll third_party/freetype-android/src to VER-2-6-2. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log... This updates from VER-2-6-1 + 1 to VER-2-6-2. It is expected that this will change the weight of CFF fonts. If this becomes undesireable, there is a patch which can be applied. BUG=chromium:551028 Committed: https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f Cr-Commit-Position: refs/heads/master@{#364438} ========== to ========== Roll third_party/freetype-android/src to VER-2-6-2. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log... This updates from VER-2-6-1 + 1 to VER-2-6-2. It is expected that this will change the weight of CFF fonts. If this becomes undesireable, there is a patch which can be applied. BUG=chromium:551028 Committed: https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f Cr-Commit-Position: refs/heads/master@{#364438} Committed: https://crrev.com/89e75f4d6c033ba5904cc808feb1292e8f211120 Cr-Commit-Position: refs/heads/master@{#364723} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/89e75f4d6c033ba5904cc808feb1292e8f211120 Cr-Commit-Position: refs/heads/master@{#364723}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1517033004/ by nyquist@chromium.org. The reason for reverting is: This is still breaking the WebKit Android (Nexus4) bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28N... Failing tests (in case link goes dead): webkit_tests unexpected_failures: css1/classification/list_style.html svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg css1/formatting_model/horizontal_formatting.html css1/formatting_model/canvas.html css1/cascade/important.html css1/font_properties/font_style.html css1/font_properties/font_variant.html css1/color_and_background/background_color.html css1/classification/list_style_position.html svg/batik/text/textAnchor3.svg fast/text/chromium-linux-fontconfig-renderstyle.html svg/canvas/canvas-pattern-svg.html css1/color_and_background/color.html fast/hidpi/clip-text-in-hidpi.html editing/caret/caret-color.html css1/classification/list_style_image.html css1/text_properties/text_align.html fast/invalid/009.html fast/compact/002.html.
Message was sent while issue was closed.
Description was changed from ========== Roll third_party/freetype-android/src to VER-2-6-2. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log... This updates from VER-2-6-1 + 1 to VER-2-6-2. It is expected that this will change the weight of CFF fonts. If this becomes undesireable, there is a patch which can be applied. BUG=chromium:551028 Committed: https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f Cr-Commit-Position: refs/heads/master@{#364438} Committed: https://crrev.com/89e75f4d6c033ba5904cc808feb1292e8f211120 Cr-Commit-Position: refs/heads/master@{#364723} ========== to ========== Roll third_party/freetype-android/src to VER-2-6-2. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log... This updates from VER-2-6-1 + 1 to VER-2-6-2. It is expected that this will change the weight of CFF fonts. If this becomes undesireable, there is a patch which can be applied. BUG=chromium:551028 Committed: https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f Cr-Commit-Position: refs/heads/master@{#364438} Committed: https://crrev.com/89e75f4d6c033ba5904cc808feb1292e8f211120 Cr-Commit-Position: refs/heads/master@{#364723} ==========
The CQ bit was checked by bungeman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wangxianzhu@chromium.org Link to the patchset: https://codereview.chromium.org/1518643003/#ps40001 (title: "Use NeedsManualRebaseline to avoid build misattribution by rebaseline-bot.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518643003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518643003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by bungeman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518643003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518643003/40001
Message was sent while issue was closed.
Description was changed from ========== Roll third_party/freetype-android/src to VER-2-6-2. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log... This updates from VER-2-6-1 + 1 to VER-2-6-2. It is expected that this will change the weight of CFF fonts. If this becomes undesireable, there is a patch which can be applied. BUG=chromium:551028 Committed: https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f Cr-Commit-Position: refs/heads/master@{#364438} Committed: https://crrev.com/89e75f4d6c033ba5904cc808feb1292e8f211120 Cr-Commit-Position: refs/heads/master@{#364723} ========== to ========== Roll third_party/freetype-android/src to VER-2-6-2. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log... This updates from VER-2-6-1 + 1 to VER-2-6-2. It is expected that this will change the weight of CFF fonts. If this becomes undesireable, there is a patch which can be applied. BUG=chromium:551028 Committed: https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f Cr-Commit-Position: refs/heads/master@{#364438} Committed: https://crrev.com/89e75f4d6c033ba5904cc808feb1292e8f211120 Cr-Commit-Position: refs/heads/master@{#364723} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Roll third_party/freetype-android/src to VER-2-6-2. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log... This updates from VER-2-6-1 + 1 to VER-2-6-2. It is expected that this will change the weight of CFF fonts. If this becomes undesireable, there is a patch which can be applied. BUG=chromium:551028 Committed: https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f Cr-Commit-Position: refs/heads/master@{#364438} Committed: https://crrev.com/89e75f4d6c033ba5904cc808feb1292e8f211120 Cr-Commit-Position: refs/heads/master@{#364723} ========== to ========== Roll third_party/freetype-android/src to VER-2-6-2. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log... This updates from VER-2-6-1 + 1 to VER-2-6-2. It is expected that this will change the weight of CFF fonts. If this becomes undesireable, there is a patch which can be applied. BUG=chromium:551028 Committed: https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f Cr-Commit-Position: refs/heads/master@{#364438} Committed: https://crrev.com/89e75f4d6c033ba5904cc808feb1292e8f211120 Cr-Commit-Position: refs/heads/master@{#364723} Committed: https://crrev.com/d7a2a013501967e6762c0028697e1eab758e711e Cr-Commit-Position: refs/heads/master@{#364850} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/d7a2a013501967e6762c0028697e1eab758e711e Cr-Commit-Position: refs/heads/master@{#364850} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
