gm/imageblur.cpp - Issue 1518643002: SkBlurImageFilter returns input when sigma = 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/imageblur.cpp

Issue 1518643002: SkBlurImageFilter returns input when sigma = 0 (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: safe refcnt Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/imageblur.cpp

diff --git a/gm/imageblur.cpp b/gm/imageblur.cpp

index 575f02c095a0aacd4b98c954de0f58452c525e87..3536de0f081fcd244d7c824c79d9a17697be8112 100644

--- a/gm/imageblur.cpp

+++ b/gm/imageblur.cpp

@@ -14,7 +14,8 @@

void imageblurgm_draw(SkScalar fSigmaX, SkScalar fSigmaY, SkCanvas* canvas) {

SkPaint paint;

- paint.setImageFilter(SkBlurImageFilter::Create(fSigmaX, fSigmaY))->unref();

+ SkAutoTUnref<SkImageFilter> blur(SkBlurImageFilter::Create(fSigmaX, fSigmaY));

+ paint.setImageFilter(blur.get());

canvas->saveLayer(nullptr, &paint);

const char* str = "The quick brown fox jumped over the lazy dog.";