gm/imageblurtiled.cpp - Issue 1518643002: SkBlurImageFilter returns input when sigma = 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/imageblurtiled.cpp

Issue 1518643002: SkBlurImageFilter returns input when sigma = 0 (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: fix call sites Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/imageblurtiled.cpp

diff --git a/gm/imageblurtiled.cpp b/gm/imageblurtiled.cpp

index 68e5785ddfd81f3328c0883ab6c04560962b2f8a..233ad602bb51c3590b62b24b37b3c3375c83e487 100644

--- a/gm/imageblurtiled.cpp

+++ b/gm/imageblurtiled.cpp

@@ -31,7 +31,8 @@ protected:

virtual void onDraw(SkCanvas* canvas) {

SkPaint paint;

- paint.setImageFilter(SkBlurImageFilter::Create(fSigmaX, fSigmaY))->unref();

+ SkAutoTUnref<SkImageFilter> blur(SkBlurImageFilter::Create(fSigmaX, fSigmaY));

+ paint.setImageFilter(blur.get());

const SkScalar tile_size = SkIntToScalar(128);

SkRect bounds;

if (!canvas->getClipBounds(&bounds)) {