Support for server session cache.

net/socket/ssl_server_socket.h

Index: net/socket/ssl_server_socket.h
diff --git a/net/socket/ssl_server_socket.h b/net/socket/ssl_server_socket.h
index bfbe7de91107bda3b35a7e1315ae3bb7c41650ae..cdd2655ed7cbdac2a97b38c63129612d73bee94a 100644
--- a/net/socket/ssl_server_socket.h
+++ b/net/socket/ssl_server_socket.h
@@ -31,6 +31,19 @@ class SSLServerSocket : public SSLSocket {
   virtual int Handshake(const CompletionCallback& callback) = 0;
 };
 
+class SSLServerSocketContext {

[davidben, 2016/01/22 23:57:48]

svaldez has been calling the corresponding client API 'SSLClientContext' which
is a little shorter.

[ryanchung, 2016/01/29 23:28:15]

Done. Will call it SSLServerContext.

+ public:
+  // Creates an SSL server socket over an already-connected transport socket.

[davidben, 2016/01/22 23:57:47]

Add: The caller must ensure the returned socket does not outlive the server
context.

[ryanchung, 2016/01/29 23:28:15]

Done.

+  //
+  // The returned SSLServerSocket takes ownership of |socket|.  Stubbed versions
+  // of CreateSSLServerSocket will delete |socket| and return NULL.

[davidben, 2016/01/22 23:57:47]

What do you mean stubbed versions? Nothing every checks that the return value is
nullptr and it doesn't really make sense for this to return nullptr. The
interface shouldn't be documented to do that.

[davidben, 2016/01/22 23:57:48]

This is already expressed in the function signature.

[ryanchung, 2016/01/29 23:28:15]

Whoops, looks like an outdated comment I accidentally moved from the original
CreateSSLServerSocket. Will remove.

[ryanchung, 2016/01/29 23:28:15]

Done.

+  //
+  // The caller starts the SSL server handshake by calling Handshake on the
+  // returned socket.
+  virtual scoped_ptr<SSLServerSocket> CreateSSLServerSocket(
+      scoped_ptr<StreamSocket> socket) = 0;
+};
+
 // Configures the underlying SSL library for the use of SSL server sockets.
 //
 // Due to the requirements of the underlying libraries, this should be called
@@ -41,18 +54,14 @@ class SSLServerSocket : public SSLSocket {
 // omitted.
 NET_EXPORT void EnableSSLServerSockets();
 
-// Creates an SSL server socket over an already-connected transport socket.
-// The caller must provide the server certificate and private key to use.
+// Creates an SSL server socket context where all sockets spawned using this
+// context will share the same session cache.
 //
-// The returned SSLServerSocket takes ownership of |socket|.  Stubbed versions
-// of CreateSSLServerSocket will delete |socket| and return NULL.
+// The caller must provide the server certificate and private key to use.
 // It takes a reference to |certificate|.
 // The |key| and |ssl_config| parameters are copied.
 //
-// The caller starts the SSL server handshake by calling Handshake on the
-// returned socket.
-NET_EXPORT scoped_ptr<SSLServerSocket> CreateSSLServerSocket(
-    scoped_ptr<StreamSocket> socket,
+NET_EXPORT scoped_ptr<SSLServerSocketContext> CreateSSLServerSocketContext(

[davidben, 2016/01/22 23:57:48]

Ditto re SSLServerSocketContext vs SSLServerContext.

[ryanchung, 2016/01/29 23:28:15]

Done.

     X509Certificate* certificate,
     const crypto::RSAPrivateKey& key,
     const SSLServerConfig& ssl_config);