Support for server session cache.

net/test/embedded_test_server/embedded_test_server.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/embedded_test_server/embedded_test_server.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
@@ skipping 274 matching lines @@
   std::vector<std::string> headers;
   headers.push_back("PRIVATE KEY");
   PEMTokenizer pem_tokenizer(key_string, headers);
   pem_tokenizer.GetNext();
   std::vector<uint8_t> key_vector;
   key_vector.assign(pem_tokenizer.data().begin(), pem_tokenizer.data().end());
 
   scoped_ptr<crypto::RSAPrivateKey> server_key(
       crypto::RSAPrivateKey::CreateFromPrivateKeyInfo(key_vector));
 
-  return CreateSSLServerSocket(std::move(connection), GetCertificate().get(),
-                               *server_key, ssl_config_);
+  scoped_ptr<SSLServerSocketContext> context = CreateSSLServerSocketContext(
+      GetCertificate().get(), *server_key, ssl_config_);
+
+  return context->CreateSSLServerSocket(std::move(connection));

[davidben, 2016/01/22 23:57:48]

The socket should not outlive the context, nor should you create a separate
context for each connection. There should be one SSLServerSocketContext for the
EmbeddedTestServer so ETS can do tests with a session cache.

[ryanchung, 2016/01/29 23:28:16]

I moved the context creation to InitializeAndListene(). Could you please help me
check if I'm putting the context initialization in the right place? I'm not too
familiar with the code here. Thanks!

 }
 
 void EmbeddedTestServer::DoAcceptLoop() {
   int rv = OK;
   while (rv == OK) {
     rv = listen_socket_->Accept(
         &accepted_socket_, base::Bind(&EmbeddedTestServer::OnAcceptCompleted,
                                       base::Unretained(this)));
     if (rv == ERR_IO_PENDING)
       return;
@@ skipping 115 matching lines @@
                                                    run_loop.QuitClosure())) {
     return false;
   }
   run_loop.Run();
 
   return true;
 }
 
 }  // namespace test_server
 }  // namespace net