Get rid of most uses of CFX_PtrArray.

core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "parser_int.h"
 
 #include <set>
 #include <utility>
@@ skipping 2675 matching lines @@
   CPDF_Dictionary* GetPage(int index);
 
   friend class CPDF_HintTables;
 
  protected:
   static const int kMaxDataAvailRecursionDepth = 64;
   static int s_CurrentDataAvailRecursionDepth;
   static const int kMaxPageRecursionDepth = 1024;
 
   FX_DWORD GetObjectSize(FX_DWORD objnum, FX_FILESIZE& offset);
-  FX_BOOL IsObjectsAvail(CFX_PtrArray& obj_array,
+  FX_BOOL IsObjectsAvail(CFX_ArrayTemplate<CPDF_Object*>& obj_array,
                          FX_BOOL bParsePage,
                          IFX_DownloadHints* pHints,
-                         CFX_PtrArray& ret_array);
+                         CFX_ArrayTemplate<CPDF_Object*>& ret_array);
   FX_BOOL CheckDocStatus(IFX_DownloadHints* pHints);
   FX_BOOL CheckHeader(IFX_DownloadHints* pHints);
   FX_BOOL CheckFirstPage(IFX_DownloadHints* pHints);
   FX_BOOL CheckHintTables(IFX_DownloadHints* pHints);
   FX_BOOL CheckEnd(IFX_DownloadHints* pHints);
   FX_BOOL CheckCrossRef(IFX_DownloadHints* pHints);
   FX_BOOL CheckCrossRefItem(IFX_DownloadHints* pHints);
   FX_BOOL CheckTrailer(IFX_DownloadHints* pHints);
   FX_BOOL CheckRoot(IFX_DownloadHints* pHints);
   FX_BOOL CheckInfo(IFX_DownloadHints* pHints);
@@ skipping 78 matching lines @@
   FX_FILESIZE m_dwCurrentOffset;
 
   PDF_DATAAVAIL_STATUS m_docStatus;
 
   FX_FILESIZE m_dwFileLen;
 
   CPDF_Document* m_pDocument;
 
   CPDF_SortObjNumArray m_objnum_array;
 
-  CFX_PtrArray m_objs_array;
+  CFX_ArrayTemplate<CPDF_Object*> m_objs_array;
 
   FX_FILESIZE m_Pos;
 
   FX_FILESIZE m_bufferOffset;
 
   FX_DWORD m_bufferSize;
 
   CFX_ByteString m_WordBuf;
 
   uint8_t m_WordBuffer[257];
@@ skipping 31 matching lines @@
   FX_BOOL m_bAnnotsLoad;
 
   FX_BOOL m_bHaveAcroForm;
 
   FX_DWORD m_dwAcroFormObjNum;
 
   FX_BOOL m_bAcroFormLoad;
 
   CPDF_Object* m_pAcroForm;
 
-  CFX_PtrArray m_arrayAcroforms;
+  CFX_ArrayTemplate<CPDF_Object*> m_arrayAcroforms;
 
   CPDF_Dictionary* m_pPageDict;
 
   CPDF_Object* m_pPageResource;
 
   FX_BOOL m_bNeedDownLoadResource;
 
   FX_BOOL m_bPageLoadedOK;
 
   FX_BOOL m_bLinearizedFormParamLoad;
 
-  CFX_PtrArray m_PagesArray;
+  CFX_ArrayTemplate<CPDF_Object*> m_PagesArray;
 
   FX_DWORD m_dwEncryptObjNum;
 
   FX_FILESIZE m_dwPrevXRefOffset;
 
   FX_BOOL m_bTotalLoadPageTree;
 
   FX_BOOL m_bCurPageDictLoadOK;
 
   CPDF_PageNode m_pageNodes;
@@ skipping 74 matching lines @@
   }
   if (m_pRoot) {
     m_pRoot->Release();
   }
   if (m_pTrailer) {
     m_pTrailer->Release();
   }
 
   int iSize = m_arrayAcroforms.GetSize();
   for (int i = 0; i < iSize; ++i) {
-    static_cast<CPDF_Object*>(m_arrayAcroforms.GetAt(i))->Release();
+    m_arrayAcroforms.GetAt(i)->Release();
   }
 }
 void CPDF_DataAvail::SetDocument(CPDF_Document* pDoc) {
   m_pDocument = pDoc;
 }
 FX_DWORD CPDF_DataAvail::GetObjectSize(FX_DWORD objnum, FX_FILESIZE& offset) {
   CPDF_Parser* pParser = (CPDF_Parser*)(m_pDocument->GetParser());
   if (pParser == NULL) {
     return 0;
   }
@@ skipping 16 matching lines @@
     }
     if ((FX_FILESIZE*)pResult -
             (FX_FILESIZE*)pParser->m_SortedOffset.GetData() ==
         pParser->m_SortedOffset.GetSize() - 1) {
       return 0;
     }
     return (FX_DWORD)(((FX_FILESIZE*)pResult)[1] - offset);
   }
   return 0;
 }
-FX_BOOL CPDF_DataAvail::IsObjectsAvail(CFX_PtrArray& obj_array,
-                                       FX_BOOL bParsePage,
-                                       IFX_DownloadHints* pHints,
-                                       CFX_PtrArray& ret_array) {
+FX_BOOL CPDF_DataAvail::IsObjectsAvail(
+    CFX_ArrayTemplate<CPDF_Object*>& obj_array,
+    FX_BOOL bParsePage,
+    IFX_DownloadHints* pHints,
+    CFX_ArrayTemplate<CPDF_Object*>& ret_array) {
   if (!obj_array.GetSize()) {
     return TRUE;
   }
   FX_DWORD count = 0;
-  CFX_PtrArray new_obj_array;
+  CFX_ArrayTemplate<CPDF_Object*> new_obj_array;
   int32_t i = 0;
   for (i = 0; i < obj_array.GetSize(); i++) {
-    CPDF_Object* pObj = static_cast<CPDF_Object*>(obj_array[i]);
+    CPDF_Object* pObj = obj_array[i];
     if (!pObj)
       continue;
 
     int32_t type = pObj->GetType();
     switch (type) {
       case PDFOBJ_ARRAY: {
         CPDF_Array* pArray = pObj->GetArray();
         for (FX_DWORD k = 0; k < pArray->GetCount(); k++) {
           new_obj_array.Add(pArray->GetElement(k));
         }
@@ skipping 33 matching lines @@
           if (pReferred) {
             new_obj_array.Add(pReferred);
           }
         }
       } break;
     }
   }
   if (count > 0) {
     int32_t iSize = new_obj_array.GetSize();
     for (i = 0; i < iSize; ++i) {
-      CPDF_Object* pObj = static_cast<CPDF_Object*>(new_obj_array[i]);
+      CPDF_Object* pObj = new_obj_array[i];
       if (CPDF_Reference* pRef = pObj->AsReference()) {
         FX_DWORD dwNum = pRef->GetRefObjNum();
         if (!m_objnum_array.Find(dwNum))
           ret_array.Add(pObj);
       } else {
         ret_array.Add(pObj);
       }
     }
     return FALSE;
   }
@@ skipping 15 matching lines @@
       return DataNotAvailable;
     }
   }
   return DataAvailable;
 }
 
 FX_BOOL CPDF_DataAvail::CheckAcroFormSubObject(IFX_DownloadHints* pHints) {
   if (!m_objs_array.GetSize()) {
     m_objs_array.RemoveAll();
     m_objnum_array.RemoveAll();
-    CFX_PtrArray obj_array;
+    CFX_ArrayTemplate<CPDF_Object*> obj_array;
     obj_array.Append(m_arrayAcroforms);
     FX_BOOL bRet = IsObjectsAvail(obj_array, FALSE, pHints, m_objs_array);
     if (bRet) {
       m_objs_array.RemoveAll();
     }
     return bRet;
   }
-  CFX_PtrArray new_objs_array;
+  CFX_ArrayTemplate<CPDF_Object*> new_objs_array;
   FX_BOOL bRet = IsObjectsAvail(m_objs_array, FALSE, pHints, new_objs_array);
   if (bRet) {
     int32_t iSize = m_arrayAcroforms.GetSize();
     for (int32_t i = 0; i < iSize; ++i) {
-      static_cast<CPDF_Object*>(m_arrayAcroforms.GetAt(i))->Release();
+      m_arrayAcroforms.GetAt(i)->Release();
     }
     m_arrayAcroforms.RemoveAll();
   } else {
     m_objs_array.RemoveAll();
     m_objs_array.Append(new_objs_array);
   }
   return bRet;
 }
 FX_BOOL CPDF_DataAvail::CheckAcroForm(IFX_DownloadHints* pHints) {
   FX_BOOL bExist = FALSE;
@@ skipping 265 matching lines @@
     }
     pObj->Release();
   }
   m_PageObjList.RemoveAll();
   if (UnavailObjList.GetSize()) {
     m_PageObjList.Append(UnavailObjList);
     return FALSE;
   }
   FX_DWORD iPages = m_PagesArray.GetSize();
   for (FX_DWORD i = 0; i < iPages; i++) {
-    CPDF_Object* pPages = static_cast<CPDF_Object*>(m_PagesArray.GetAt(i));
+    CPDF_Object* pPages = m_PagesArray.GetAt(i);
     if (!pPages)
       continue;
 
     if (!GetPageKids(m_pCurrentParser, pPages)) {
       pPages->Release();
       while (++i < iPages) {
-        pPages = static_cast<CPDF_Object*>(m_PagesArray.GetAt(i));
+        pPages = m_PagesArray.GetAt(i);
         pPages->Release();
       }
       m_PagesArray.RemoveAll();
       m_docStatus = PDF_DATAAVAIL_ERROR;
       return FALSE;
     }
     pPages->Release();
   }
   m_PagesArray.RemoveAll();
   if (!m_PageObjList.GetSize()) {
@@ skipping 744 matching lines @@
                                       int level) {
   if (level >= kMaxPageRecursionDepth) {
     return FALSE;
   }
   int32_t iSize = pageNodes.m_childNode.GetSize();
   if (iSize <= 0 || iPage >= iSize) {
     m_docStatus = PDF_DATAAVAIL_ERROR;
     return FALSE;
   }
   for (int32_t i = 0; i < iSize; ++i) {
-    CPDF_PageNode* pNode = (CPDF_PageNode*)pageNodes.m_childNode.GetAt(i);
+    CPDF_PageNode* pNode = pageNodes.m_childNode.GetAt(i);
     if (!pNode) {
       continue;
     }
     switch (pNode->m_type) {
       case PDF_PAGENODE_UNKOWN:
         if (!CheckUnkownPageNode(pNode->m_dwPageNo, pNode, pHints)) {
           return FALSE;
         }
         --i;
         break;
@@ skipping 126 matching lines @@
     m_objs_array.RemoveAll();
     m_objnum_array.RemoveAll();
     CPDF_Dictionary* pPageDict = m_pDocument->GetPage(iPage);
     if (!pPageDict) {
       return TRUE;
     }
     CPDF_Object* pAnnots = pPageDict->GetElement(FX_BSTRC("Annots"));
     if (!pAnnots) {
       return TRUE;
     }
-    CFX_PtrArray obj_array;
+    CFX_ArrayTemplate<CPDF_Object*> obj_array;
     obj_array.Add(pAnnots);
     FX_BOOL bRet = IsObjectsAvail(obj_array, FALSE, pHints, m_objs_array);
     if (bRet) {
       m_objs_array.RemoveAll();
     }
     return bRet;
   }
-  CFX_PtrArray new_objs_array;
+  CFX_ArrayTemplate<CPDF_Object*> new_objs_array;
   FX_BOOL bRet = IsObjectsAvail(m_objs_array, FALSE, pHints, new_objs_array);
   m_objs_array.RemoveAll();
   if (!bRet) {
     m_objs_array.Append(new_objs_array);
   }
   return bRet;
 }
 FX_BOOL CPDF_DataAvail::CheckLinearizedFirstPage(int32_t iPage,
                                                  IFX_DownloadHints* pHints) {
   if (!m_bAnnotsLoad) {
@@ skipping 93 matching lines @@
   }
   if (!m_bPageLoadedOK) {
     if (!m_objs_array.GetSize()) {
       m_objs_array.RemoveAll();
       m_objnum_array.RemoveAll();
       m_pPageDict = m_pDocument->GetPage(iPage);
       if (!m_pPageDict) {
         ResetFirstCheck(iPage);
         return DataAvailable;
       }
-      CFX_PtrArray obj_array;
+      CFX_ArrayTemplate<CPDF_Object*> obj_array;
       obj_array.Add(m_pPageDict);
       FX_BOOL bRet = IsObjectsAvail(obj_array, TRUE, pHints, m_objs_array);
       if (bRet) {
         m_objs_array.RemoveAll();
         m_bPageLoadedOK = TRUE;
       } else {
         return bRet;
       }
     } else {
-      CFX_PtrArray new_objs_array;
+      CFX_ArrayTemplate<CPDF_Object*> new_objs_array;
       FX_BOOL bRet =
           IsObjectsAvail(m_objs_array, FALSE, pHints, new_objs_array);
       m_objs_array.RemoveAll();
       if (bRet) {
         m_bPageLoadedOK = TRUE;
       } else {
         m_objs_array.Append(new_objs_array);
         return DataNotAvailable;
       }
     }
@@ skipping 24 matching lines @@
   m_bPageLoadedOK = FALSE;
   m_bAnnotsLoad = FALSE;
   m_bCurPageDictLoadOK = FALSE;
   ResetFirstCheck(iPage);
   m_pagesLoadState.insert(iPage);
   return DataAvailable;
 }
 FX_BOOL CPDF_DataAvail::CheckResources(IFX_DownloadHints* pHints) {
   if (!m_objs_array.GetSize()) {
     m_objs_array.RemoveAll();
-    CFX_PtrArray obj_array;
+    CFX_ArrayTemplate<CPDF_Object*> obj_array;
     obj_array.Add(m_pPageResource);
     FX_BOOL bRet = IsObjectsAvail(obj_array, TRUE, pHints, m_objs_array);
     if (bRet) {
       m_objs_array.RemoveAll();
     }
     return bRet;
   }
-  CFX_PtrArray new_objs_array;
+  CFX_ArrayTemplate<CPDF_Object*> new_objs_array;
   FX_BOOL bRet = IsObjectsAvail(m_objs_array, FALSE, pHints, new_objs_array);
   m_objs_array.RemoveAll();
   if (!bRet) {
     m_objs_array.Append(new_objs_array);
   }
   return bRet;
 }
 void CPDF_DataAvail::GetLinearizedMainXRefInfo(FX_FILESIZE* pPos,
                                                FX_DWORD* pSize) {
   if (pPos) {
@@ skipping 54 matching lines @@
       return FormNotExist;
     }
     if (!CheckLinearizedData(pHints)) {
       return FormNotAvailable;
     }
     if (!m_objs_array.GetSize()) {
       m_objs_array.Add(pAcroForm->GetDict());
     }
     m_bLinearizedFormParamLoad = TRUE;
   }
-  CFX_PtrArray new_objs_array;
+  CFX_ArrayTemplate<CPDF_Object*> new_objs_array;
   FX_BOOL bRet = IsObjectsAvail(m_objs_array, FALSE, pHints, new_objs_array);
   m_objs_array.RemoveAll();
   if (!bRet) {
     m_objs_array.Append(new_objs_array);
     return FormNotAvailable;
   }
   return FormAvailable;
 }
 void CPDF_SortObjNumArray::AddObjNum(FX_DWORD dwObjNum) {
   int32_t iNext = 0;
@@ skipping 18 matching lines @@
     if (m_number_array.GetAt(iMid) > value) {
       iHigh = iMid - 1;
     } else if (m_number_array.GetAt(iMid) < value) {
       iLow = iMid + 1;
     }
   }
   iNext = iLow;
   return FALSE;
 }
 CPDF_PageNode::~CPDF_PageNode() {
-  int32_t iSize = m_childNode.GetSize();
-  for (int32_t i = 0; i < iSize; ++i) {
-    CPDF_PageNode* pNode = (CPDF_PageNode*)m_childNode[i];
-    delete pNode;
+  for (int32_t i = 0; i < m_childNode.GetSize(); ++i) {
+    delete m_childNode[i];
   }
   m_childNode.RemoveAll();
 }
 CPDF_HintTables::~CPDF_HintTables() {
   m_dwDeltaNObjsArray.RemoveAll();
   m_dwNSharedObjsArray.RemoveAll();
   m_dwSharedObjNumArray.RemoveAll();
   m_dwIdentifierArray.RemoveAll();
   m_szPageOffsetArray.RemoveAll();
   m_szSharedObjOffsetArray.RemoveAll();
@@ skipping 312 matching lines @@
   if (!m_pLinearizedDict)
     return -1;
   CPDF_Array* pRange = m_pLinearizedDict->GetArray(FX_BSTRC("H"));
   if (!pRange)
     return -1;
   CPDF_Object* pStreamLen = pRange->GetElementValue(1);
   if (!pStreamLen)
     return -1;
   return pStreamLen->GetInteger();
 }