Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 1518573002: RegisterAllocator: Clean up before adding aliasing. (Closed)

Created:
5 years ago by bbudge
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

RegisterAllocator: Clean up before adding aliasing. Remove some unused fields in RegisterAllocationData. Move some DCHECKS about configuration constraints. Rename kMaxDoubleRegisters -> kMaxFPRegisters LOG=N BUG=v8:4124 Committed: https://crrev.com/d565ba8ff3e4084999e0faf3d9617c2419cbad5a Cr-Commit-Position: refs/heads/master@{#35777}

Patch Set 1 #

Patch Set 2 : Move DCHECKS. #

Patch Set 3 : Rename kMaxDoubleRegisters -> kMaxFPRegisters #

Patch Set 4 : Rebase #

Patch Set 5 : Fix compile. #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -23 lines) Patch
M src/compiler/register-allocator.h View 1 2 3 4 5 2 chunks +1 line, -5 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 4 5 5 chunks +4 lines, -12 lines 0 comments Download
M src/register-configuration.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/register-configuration.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.cc View 1 2 3 4 5 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
bbudge
5 years ago (2015-12-09 21:57:09 UTC) #2
Mircea Trofin
On 2015/12/09 21:57:09, bbudge wrote: LGTM
5 years ago (2015-12-09 23:15:38 UTC) #3
bbudge
Mircea, I added some changes since your review.
5 years ago (2015-12-15 00:51:58 UTC) #6
Mircea Trofin
On 2015/12/15 00:51:58, bbudge wrote: > Mircea, I added some changes since your review. lgtm.
5 years ago (2015-12-15 01:15:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518573002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518573002/100001
4 years, 8 months ago (2016-04-25 17:26:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14120)
4 years, 8 months ago (2016-04-25 17:29:35 UTC) #12
bbudge
+Benedikt for OWNERS
4 years, 8 months ago (2016-04-25 18:02:39 UTC) #14
Benedikt Meurer
LGTM.
4 years, 8 months ago (2016-04-25 18:04:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518573002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518573002/100001
4 years, 8 months ago (2016-04-25 20:07:56 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-04-25 20:10:39 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 20:11:51 UTC) #21
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/d565ba8ff3e4084999e0faf3d9617c2419cbad5a
Cr-Commit-Position: refs/heads/master@{#35777}

Powered by Google App Engine
This is Rietveld 408576698