Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1518553002: Use annotations on confuse() functions (Closed)

Created:
5 years ago by sra1
Modified:
5 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -18 lines) Patch
M tests/language/const_map2_test.dart View 1 chunk +2 lines, -4 lines 1 comment Download
M tests/language/const_map_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M tests/language/range_analysis3_test.dart View 2 chunks +3 lines, -9 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
sra1
Committed patchset #1 (id:1) manually as ec5e0c3d29c47123854499799a132285346b2833 (presubmit successful).
5 years ago (2015-12-09 20:30:13 UTC) #2
sra1
5 years ago (2015-12-09 20:33:13 UTC) #4
floitsch
5 years ago (2015-12-09 20:40:15 UTC) #5
Message was sent while issue was closed.
LGTM with one comment.

https://codereview.chromium.org/1518553002/diff/1/tests/language/const_map2_t...
File tests/language/const_map2_test.dart (right):

https://codereview.chromium.org/1518553002/diff/1/tests/language/const_map2_t...
tests/language/const_map2_test.dart:17: @NoInline() @AssumeDynamic()
I would put them on separate lines, but I really don't mind if they stay the way
they are.

Since we seem to combine @NoInline() and @AssumeDynamic() a lot, it might be
worthwhile adding a new annotation to the test-package (providing both).

https://codereview.chromium.org/1518553002/diff/1/tests/language/range_analys...
File tests/language/range_analysis3_test.dart (right):

https://codereview.chromium.org/1518553002/diff/1/tests/language/range_analys...
tests/language/range_analysis3_test.dart:7: @NoInline() @AssumeDynamic()
Actually the confuse here was still making sure that the return type is an int.

Powered by Google App Engine
This is Rietveld 408576698