chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc - Issue 1518543002: Adds MD ink ripple animations to buttons within location bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc

Issue 1518543002: Adds MD ink ripple animations to buttons within location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adds MD ink ripple animations to buttons within location bar (missing member init) Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc b/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc

index 6c360a491f94e387b80faafe3c08c1e5f2b4f077..52948d675de587cd9eca1c2cdf94fff61a10935a 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc

@@ -43,6 +43,10 @@ class ManagePasswordsIconViewTest : public ManagePasswordsTest {

return tooltip;

}

+ const gfx::ImageSkia& GetImage() {

+ return GetView()->GetImage();

+ }

private:

DISALLOW_COPY_AND_ASSIGN(ManagePasswordsIconViewTest);

};

@@ -58,7 +62,7 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsIconViewTest, PendingState) {

EXPECT_TRUE(GetView()->visible());

// No tooltip because the bubble is showing.

EXPECT_EQ(base::string16(), GetTooltipText());

- const gfx::ImageSkia active_image = GetView()->GetImage();

+ const gfx::ImageSkia active_image = GetImage();

}

IN_PROC_BROWSER_TEST_F(ManagePasswordsIconViewTest, ManageState) {