Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3241)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1518543002: Adds MD ink ripple animations to buttons within location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds MD ink ripple animations to buttons within location bar (missing member init) Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 2d7a8e089ccc313d358f640e460bb87708fca26b..192ad02d4c97974b1972d26fea230c4e0d3ca6cb 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -1288,10 +1288,11 @@ void BrowserView::ShowBookmarkBubble(const GURL& url, bool already_bookmarked) {
scoped_ptr<BubbleSyncPromoDelegate> delegate;
delegate.reset(new BookmarkBubbleSignInDelegate(browser_.get()));
- BookmarkBubbleView::ShowBubble(GetToolbarView()->GetBookmarkBubbleAnchor(),
- gfx::Rect(), nullptr, bookmark_bar_view_.get(),
- std::move(delegate), browser_->profile(), url,
- already_bookmarked);
+ views::View* anchor_view = GetToolbarView()->GetBookmarkBubbleAnchor();
+ views::Widget* bubble_widget = BookmarkBubbleView::ShowBubble(
+ anchor_view, gfx::Rect(), nullptr, bookmark_bar_view_.get(),
+ std::move(delegate), browser_->profile(), url, already_bookmarked);
+ GetToolbarView()->OnBubbleCreatedForAnchor(anchor_view, bubble_widget);
}
void BrowserView::ShowBookmarkAppBubble(
@@ -1304,9 +1305,10 @@ autofill::SaveCardBubbleView* BrowserView::ShowSaveCreditCardBubble(
content::WebContents* web_contents,
autofill::SaveCardBubbleController* controller,
bool is_user_gesture) {
+ views::View* anchor_view = GetToolbarView()->GetSaveCreditCardBubbleAnchor();
autofill::SaveCardBubbleViews* view = new autofill::SaveCardBubbleViews(
- GetToolbarView()->GetSaveCreditCardBubbleAnchor(), web_contents,
- controller);
+ anchor_view, web_contents, controller);
+ GetToolbarView()->OnBubbleCreatedForAnchor(anchor_view, view->GetWidget());
view->Show(is_user_gesture ? autofill::SaveCardBubbleViews::USER_GESTURE
: autofill::SaveCardBubbleViews::AUTOMATIC);
return view;
@@ -1333,10 +1335,12 @@ void BrowserView::ShowTranslateBubble(
if (IsMinimized())
return;
- TranslateBubbleView::ShowBubble(
- GetToolbarView()->GetTranslateBubbleAnchor(), web_contents, step,
+ views::View* anchor_view = GetToolbarView()->GetTranslateBubbleAnchor();
+ views::Widget* bubble_widget = TranslateBubbleView::ShowBubble(
+ anchor_view, web_contents, step,
error_type, is_user_gesture ? TranslateBubbleView::USER_GESTURE
: TranslateBubbleView::AUTOMATIC);
+ GetToolbarView()->OnBubbleCreatedForAnchor(anchor_view, bubble_widget);
}
#if defined(ENABLE_ONE_CLICK_SIGNIN)
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc ('k') | chrome/browser/ui/views/location_bar/bubble_icon_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698