chrome/browser/ui/views/translate/translate_bubble_view.cc - Issue 1518543002: Adds MD ink ripple animations to buttons within location bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 1518543002: Adds MD ink ripple animations to buttons within location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adds MD ink ripple animations to buttons within location bar (with WidgetObserver) Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/location_bar/bubble_icon_view.h ('K') | « chrome/browser/ui/views/translate/translate_bubble_view.h ('k') | ui/views/bubble/bubble_delegate.h » ('j') | ui/views/bubble/bubble_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/translate/translate_bubble_view.cc

diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc

index a4f83eaf8396f5e4053481ee38e8f44ac050188a..2d52bae51ca5c2f152e5d05cbd21df1c74b8341f 100644

--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc

+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc

@@ -77,7 +77,7 @@ TranslateBubbleView::~TranslateBubbleView() {

// static

void TranslateBubbleView::ShowBubble(

- views::View* anchor_view,

+ views::WidgetObserverView* anchor_view,

content::WebContents* web_contents,

translate::TranslateStep step,

translate::TranslateErrors::Type error_type,

@@ -242,7 +242,7 @@ TranslateBubbleModel::ViewState TranslateBubbleView::GetViewState() const {

}

TranslateBubbleView::TranslateBubbleView(

- views::View* anchor_view,

+ views::WidgetObserverView* anchor_view,

scoped_ptr<TranslateBubbleModel> model,

translate::TranslateErrors::Type error_type,

content::WebContents* web_contents)