chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h - Issue 1518543002: Adds MD ink ripple animations to buttons within location bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h

Issue 1518543002: Adds MD ink ripple animations to buttons within location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adds MD ink ripple animations to buttons within location bar (with WidgetObserver) Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/location_bar/bubble_icon_view.h ('K') | « chrome/browser/ui/views/location_bar/bubble_icon_view.cc ('k') | chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc » ('j') | ui/views/bubble/bubble_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h

diff --git a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h

index 13c4f7d714c68ad03940b38e6683ac80f521e75d..2f27f080ae251aca2ab6cb21ae8e752eac3aa637 100644

--- a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h

+++ b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h

@@ -9,6 +9,7 @@

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

#include "ui/views/bubble/bubble_delegate.h"

+#include "ui/views/widget/widget_observer_view.h"

namespace content {

class NotificationDetails;

@@ -33,7 +34,7 @@ class LocationBarBubbleDelegateView : public views::BubbleDelegateView,

AUTOMATIC,

};

- LocationBarBubbleDelegateView(views::View* anchor_view,

+ LocationBarBubbleDelegateView(views::WidgetObserverView* anchor_view,

content::WebContents* web_contents);

~LocationBarBubbleDelegateView() override;