chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc - Issue 1518543002: Adds MD ink ripple animations to buttons within location bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 1518543002: Adds MD ink ripple animations to buttons within location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adds MD ink ripple animations to buttons within location bar (with WidgetObserver) Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h ('k') | chrome/browser/ui/views/location_bar/bubble_icon_view.h » ('j') | chrome/browser/ui/views/location_bar/bubble_icon_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

index 620893d655570ad4800bb6737941c9f28037fd40..1d55c984c502f7544405f4c2957d7b8fd4c68eda 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

@@ -70,7 +70,7 @@ BookmarkBubbleView* BookmarkBubbleView::bookmark_bubble_ = NULL;

// static

void BookmarkBubbleView::ShowBubble(

- views::View* anchor_view,

+ views::WidgetObserverView* anchor_view,

const gfx::Rect& anchor_rect,

gfx::NativeView parent_window,

bookmarks::BookmarkBubbleObserver* observer,

@@ -283,7 +283,7 @@ views::View* BookmarkBubbleView::GetInitiallyFocusedView() {

}

BookmarkBubbleView::BookmarkBubbleView(

- views::View* anchor_view,

+ views::WidgetObserverView* anchor_view,

bookmarks::BookmarkBubbleObserver* observer,

scoped_ptr<BubbleSyncPromoDelegate> delegate,

Profile* profile,