Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1518473003: Remove workaround for VS 2015 RC bug (Closed)

Created:
5 years ago by brucedawson
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove workaround for VS 2015 RC bug R=mstarzinger@chromium.org LOG=N BUG=440500 Committed: https://crrev.com/667efbd0d7009f9923f1c28caf9d8a62b626f39e Cr-Commit-Position: refs/heads/master@{#32734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/deoptimizer.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
brucedawson
PTAL We don't need to retain workarounds for pre-release compilers after the release versions have ...
5 years ago (2015-12-09 21:39:11 UTC) #1
Michael Starzinger
LGTM. With LOG=Y, this commit shows up in the V8 ChangeLog. This is helpful for ...
5 years ago (2015-12-09 23:55:40 UTC) #2
brucedawson
Makes sense. Changed to LOG=N. Thanks.
5 years ago (2015-12-10 00:04:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518473003/1
5 years ago (2015-12-10 00:04:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 04:43:08 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-10 04:43:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/667efbd0d7009f9923f1c28caf9d8a62b626f39e
Cr-Commit-Position: refs/heads/master@{#32734}

Powered by Google App Engine
This is Rietveld 408576698