dart2js: Fix an issue with erroneous for-in.

dart2js: Fix an issue with erroneous for-in.

In the CPS backend, when a for-in loop has an erroneous variable (interpreted
as an unresolved static setter), then we should call NoSuchMethod and not try
to call the setter.  This is what the SSA backend does.

BUG=
R=asgerf@google.com

Committed: https://github.com/dart-lang/sdk/commit/42809b52b1e83dcf3ea4d205f6c413df5992c60d

[Kevin Millikin (Google), 2015-12-09 17:26:17]

kmillikin@google.com changed reviewers:
+ asgerf@google.com, johnniwinther@google.com

[Kevin Millikin (Google), 2015-12-09 17:26:18]

https://codereview.chromium.org/1518473002/diff/20001/tests/co19/co19-dart2js...
File tests/co19/co19-dart2js.status (left):

https://codereview.chromium.org/1518473002/diff/20001/tests/co19/co19-dart2js...
tests/co19/co19-dart2js.status:120: -Language/Metadata/compilation_t10:
MissingCompileTimeError # Please triage this failure
I don't know why this passes now (also with the SSA backend).  It doesn't seem
to have anything to do with this change.

[asgerf, 2015-12-09 17:31:43]

lgtm

[Kevin Millikin (Google), 2015-12-09 17:32:48]

On 2015/12/09 17:26:18, Kevin Millikin (Google) wrote:
>
https://codereview.chromium.org/1518473002/diff/20001/tests/co19/co19-dart2js...
> File tests/co19/co19-dart2js.status (left):
> 
>
https://codereview.chromium.org/1518473002/diff/20001/tests/co19/co19-dart2js...
> tests/co19/co19-dart2js.status:120: -Language/Metadata/compilation_t10:
> MissingCompileTimeError # Please triage this failure
> I don't know why this passes now (also with the SSA backend).  It doesn't seem
> to have anything to do with this change.

Actually, I do know why it passes: Johnni fixed the underlying issue but didn't
update the test expectations.

[Kevin Millikin (Google), 2015-12-09 17:33:36]

Description was changed from

==========
dart2js: Fix an issue with erroneous for-in.

In the CPS backend, when a for-in loop has an erroneous variable (interpreted
as an unresolved static setter), then we should call NoSuchMethod and not try
to call the setter.  This is what the SSA backend does.

BUG=
==========

to

==========
dart2js: Fix an issue with erroneous for-in.

In the CPS backend, when a for-in loop has an erroneous variable (interpreted
as an unresolved static setter), then we should call NoSuchMethod and not try
to call the setter.  This is what the SSA backend does.

BUG=
R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/42809b52b1e83dcf3ea4d205f6c413df5992c60d
==========

[Kevin Millikin (Google), 2015-12-09 17:33:38]

Committed patchset #2 (id:20001) manually as
42809b52b1e83dcf3ea4d205f6c413df5992c60d (presubmit successful).