Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2135)

Unified Diff: bench/SkBenchmark.h

Issue 151843002: Allow GMs ato be used as benchmarks. Make convex_poly_clip opt in. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Address comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | bench/SkGMBench.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/SkBenchmark.h
diff --git a/bench/SkBenchmark.h b/bench/SkBenchmark.h
index bf44d2cc9702f295e9bdf7f52f80c2c86256bf23..f1e317da60c71bb5286301e99d0b85827ed79548 100644
--- a/bench/SkBenchmark.h
+++ b/bench/SkBenchmark.h
@@ -13,9 +13,13 @@
#include "SkString.h"
#include "SkTRegistry.h"
-#define DEF_BENCH(code) \
-static SkBenchmark* SK_MACRO_APPEND_LINE(F_)() { code; } \
-static BenchRegistry SK_MACRO_APPEND_LINE(R_)(SK_MACRO_APPEND_LINE(F_));
+#define DEF_BENCH(code) \
+namespace { \
+class SK_MACRO_APPEND_LINE(F_CLASS) : public SkBenchmarkFactory { \
+ virtual SkBenchmark* operator()() const SK_OVERRIDE { code; } \
+} SK_MACRO_APPEND_LINE(g_F_); \
+BenchRegistry SK_MACRO_APPEND_LINE(g_R_)(&SK_MACRO_APPEND_LINE(g_F_)); \
+}
/*
* With the above macros, you can register benches as follows (at the bottom
@@ -132,6 +136,13 @@ private:
typedef SkRefCnt INHERITED;
};
-typedef SkTRegistry<SkBenchmark*(*)()> BenchRegistry;
+class SkBenchmarkFactory : public SkRefCnt {
+public:
+ // Creates a new SkBenchmark that is owned by the caller on each call.
+ virtual SkBenchmark* operator()() const = 0;
+ virtual ~SkBenchmarkFactory() {}
+};
+
+typedef SkTRegistry<SkBenchmarkFactory*> BenchRegistry;
#endif
« no previous file with comments | « no previous file | bench/SkGMBench.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698