Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1518403004: [debugger] re-enable step in frame test. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] re-enable step in frame test. Issue has long been fixed. R=jkummerow@chromium.org BUG=v8:2921 LOG=N Committed: https://crrev.com/f27105b17a23a64faeae33b939555840e388136e Cr-Commit-Position: refs/heads/master@{#32862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M test/mjsunit/debug-step-4-in-frame.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
5 years ago (2015-12-15 11:37:22 UTC) #1
Jakob Kummerow
lgtm
5 years ago (2015-12-15 11:38:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518403004/1
5 years ago (2015-12-15 11:53:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 12:11:22 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f27105b17a23a64faeae33b939555840e388136e Cr-Commit-Position: refs/heads/master@{#32862}
5 years ago (2015-12-15 12:12:06 UTC) #7
Yang
5 years ago (2015-12-15 12:45:12 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1522333003/ by yangguo@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20....

Powered by Google App Engine
This is Rietveld 408576698