Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1518383002: [DevTools] Hide "Service Worker Fallback" response from the Network tab. (Closed)

Created:
5 years ago by horo
Modified:
5 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Hide "Service Worker Fallback" response from the Network tab. This message is used for an internal response which is sent from the browser process to the page's renderer process to consider the CORS preflight logic when the Service Worker didn't handle the CORS request . This message is not only meaningless for Web developers but also confusing them. http://stackoverflow.com/questions/34035667/service-worker-making-extra-call So this cl removes the CORS fallback response from the network panel. BUG=477685 Committed: https://crrev.com/2e1de2f8f4ee2c620c43f00b2825224689046c3a Cr-Commit-Position: refs/heads/master@{#365441}

Patch Set 1 #

Total comments: 2

Patch Set 2 : incorporated pfeldman's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
horo
pfeldman@ Could you please review this?
5 years ago (2015-12-14 06:38:56 UTC) #4
pfeldman
lgtm https://codereview.chromium.org/1518383002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/1518383002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js#newcode1638 third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1638: if (request.statusText == "Service Worker Fallback Required") ===
5 years ago (2015-12-16 00:48:12 UTC) #5
horo
Thank you!! https://codereview.chromium.org/1518383002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/1518383002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js#newcode1638 third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1638: if (request.statusText == "Service Worker Fallback Required") ...
5 years ago (2015-12-16 02:27:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518383002/20001
5 years ago (2015-12-16 02:35:40 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-16 04:36:59 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-16 04:38:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2e1de2f8f4ee2c620c43f00b2825224689046c3a
Cr-Commit-Position: refs/heads/master@{#365441}

Powered by Google App Engine
This is Rietveld 408576698