Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1518323002: Canonicalize creation of ServiceWorkerContainerClient supplement. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
tkent, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Canonicalize creation of ServiceWorkerContainerClient supplement. Follow the lazy from-new-provideTo pattern used elsewhere for instantiating supplements. R=horo BUG= Committed: https://crrev.com/d8feed89b667cfad8ebb227db3fa0f7236267f56 Cr-Commit-Position: refs/heads/master@{#365230}

Patch Set 1 #

Patch Set 2 : compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -22 lines) Patch
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.cpp View 1 2 chunks +19 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
sof
please take a look.
5 years ago (2015-12-14 07:13:14 UTC) #3
horo
lgtm
5 years ago (2015-12-15 02:39:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518323002/20001
5 years ago (2015-12-15 06:37:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/154009)
5 years ago (2015-12-15 06:47:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518323002/20001
5 years ago (2015-12-15 07:25:01 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/110725)
5 years ago (2015-12-15 09:04:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518323002/20001
5 years ago (2015-12-15 10:25:45 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-15 12:05:52 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-15 12:06:34 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d8feed89b667cfad8ebb227db3fa0f7236267f56
Cr-Commit-Position: refs/heads/master@{#365230}

Powered by Google App Engine
This is Rietveld 408576698