Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1518203003: Eliminate unnecessary linear searching in i8n_template_no_process.js (Closed)

Created:
5 years ago by dpapad
Modified:
5 years ago
Reviewers:
Dan Beam
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate unnecessary linear searching in i8n_template_no_process.js BUG=568776 Committed: https://crrev.com/cdc7be3643c0b0a820a8e811d6234563b0c1580d Cr-Commit-Position: refs/heads/master@{#365308}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M ui/webui/resources/js/i18n_template_no_process.js View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
dpapad
5 years ago (2015-12-14 20:05:35 UTC) #4
Dan Beam
aight, give it a try lgtm
5 years ago (2015-12-14 20:56:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518203003/1
5 years ago (2015-12-14 22:18:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/159534)
5 years ago (2015-12-14 23:54:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518203003/1
5 years ago (2015-12-15 02:22:29 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
5 years ago (2015-12-15 04:28:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518203003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518203003/20001
5 years ago (2015-12-15 18:06:00 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-15 19:22:05 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-15 19:23:13 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cdc7be3643c0b0a820a8e811d6234563b0c1580d
Cr-Commit-Position: refs/heads/master@{#365308}

Powered by Google App Engine
This is Rietveld 408576698