chrome/browser/ui/android/toolbar/toolbar_model_android.cc - Issue 151813002: Adds InstantExtendedEnabledParam to the search request URL iff the query extraction flag is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/toolbar/toolbar_model_android.cc

Issue 151813002: Adds InstantExtendedEnabledParam to the search request URL iff the query extraction flag is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update comment Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/android/toolbar/toolbar_model_android.cc

diff --git a/chrome/browser/ui/android/toolbar/toolbar_model_android.cc b/chrome/browser/ui/android/toolbar/toolbar_model_android.cc

index 46413cb413f4c4cd491d735027cf8c5483d11d9e..fbf38428879243034a281413227e987218de7327 100644

--- a/chrome/browser/ui/android/toolbar/toolbar_model_android.cc

+++ b/chrome/browser/ui/android/toolbar/toolbar_model_android.cc

@@ -6,6 +6,7 @@

#include "base/android/jni_string.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/browser/search/search.h"

#include "chrome/browser/search_engines/search_terms_data.h"

#include "chrome/browser/ui/toolbar/toolbar_model_impl.h"

#include "content/public/browser/web_contents.h"

@@ -41,8 +42,7 @@ ScopedJavaLocalRef<jstring> ToolbarModelAndroid::GetQueryExtractionParam(

Profile::FromBrowserContext(web_contents->GetBrowserContext());

UIThreadSearchTermsData search_terms_data(profile);

return base::android::ConvertUTF8ToJavaString(

- env,

- search_terms_data.InstantExtendedEnabledParam());

+ env, chrome::InstantExtendedEnabledParam(false));

Yusuf 2014/02/04 19:02:54 I do agree with samarth we should be returning tru

kmadhusu 2014/02/04 19:39:54 Done. As we discussed offline, I filed crbug.com/3

}

ScopedJavaLocalRef<jstring> ToolbarModelAndroid::GetCorpusChipText(

« chrome/browser/search/search.cc ('K') | « chrome/browser/search_engines/template_url.cc ('k') | no next file » | no next file with comments »