Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: Source/core/rendering/RenderLayerBacking.cpp

Issue 15181006: Plumb CompositingReason from Blink to compositor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed reviewer feedback Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderLayerBacking.h ('k') | public/platform/WebCompositingReasons.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderLayerBacking.cpp
diff --git a/Source/core/rendering/RenderLayerBacking.cpp b/Source/core/rendering/RenderLayerBacking.cpp
index 7423b135b4a0d022eb141a62b2df1e6a896f805d..cc6e37f41b7035edffe8b10422f6de193915863c 100644
--- a/Source/core/rendering/RenderLayerBacking.cpp
+++ b/Source/core/rendering/RenderLayerBacking.cpp
@@ -50,6 +50,7 @@
#include "core/rendering/RenderEmbeddedObject.h"
#include "core/rendering/RenderIFrame.h"
#include "core/rendering/RenderImage.h"
+#include "core/rendering/RenderLayer.h"
#include "core/rendering/RenderLayerCompositor.h"
#include "core/rendering/RenderVideo.h"
#include "core/rendering/RenderView.h"
@@ -346,6 +347,45 @@ void RenderLayerBacking::updateAfterWidgetResize()
}
}
+void RenderLayerBacking::updateCompositingReasons()
+{
+ m_graphicsLayer->setCompositingReasons(m_owningLayer->compositingReasons());
+
+ if (m_ancestorClippingLayer)
+ m_ancestorClippingLayer->setCompositingReasons(CompositingReasonLayerForClip);
enne (OOO) 2013/05/21 20:19:28 What about just setting these reasons when you cre
+
+ if (m_contentsContainmentLayer)
+ m_contentsContainmentLayer->setCompositingReasons(CompositingReasonNone);
+
+ if (m_foregroundLayer)
+ m_foregroundLayer->setCompositingReasons(CompositingReasonLayerForForeground);
+
+ if (m_backgroundLayer)
+ m_backgroundLayer->setCompositingReasons(CompositingReasonNone);
+
+ if (m_childContainmentLayer)
+ m_childContainmentLayer->setCompositingReasons(CompositingReasonNone);
+
+ if (m_maskLayer)
+ m_maskLayer->setCompositingReasons(CompositingReasonNone);
+
+ if (m_layerForHorizontalScrollbar)
+ m_layerForHorizontalScrollbar->setCompositingReasons(CompositingReasonLayerForScrollbar);
+
+ if (m_layerForVerticalScrollbar)
+ m_layerForVerticalScrollbar->setCompositingReasons(CompositingReasonLayerForScrollbar);
+
+ if (m_layerForScrollCorner)
+ m_layerForScrollCorner->setCompositingReasons(CompositingReasonLayerForScrollbar);
+
+ // Is this the correct reason?
+ if (m_scrollingLayer)
+ m_scrollingLayer->setCompositingReasons(CompositingReasonLayerForDescendantClip);
+
+ if (m_scrollingContentsLayer)
+ m_scrollingContentsLayer->setCompositingReasons(CompositingReasonLayerForScrollingContainer);
+}
+
void RenderLayerBacking::updateAfterLayout(UpdateAfterLayoutFlags flags)
{
RenderLayerCompositor* layerCompositor = compositor();
@@ -718,6 +758,8 @@ void RenderLayerBacking::updateGraphicsLayerGeometry()
updateDrawsContent(isSimpleContainer);
updateAfterWidgetResize();
registerScrollingLayers();
+
+ updateCompositingReasons();
}
void RenderLayerBacking::registerScrollingLayers()
« no previous file with comments | « Source/core/rendering/RenderLayerBacking.h ('k') | public/platform/WebCompositingReasons.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698