Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1518073002: More build config cleanup. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

More build config cleanup. * Get rid of: use_ash, use_pango, use_cairo, use_evdev_gestures. * Delete: build/linux/system.gyp. * Note: use_aura should be removed too, but is slightly more involved. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/053630c7f265d0870501f129ec32243113310c89

Patch Set 1 #

Total comments: 2

Patch Set 2 : ERROR, not FATAL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1287 lines) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
M build/config/fnl/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
M build/config/linux/BUILD.gn View 6 chunks +42 lines, -69 lines 0 comments Download
M build/config/ui.gni View 2 chunks +0 lines, -11 lines 0 comments Download
D build/linux/system.gyp View 1 chunk +0 lines, -795 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +0 lines, -7 lines 0 comments Download
M skia/BUILD.gn View 2 chunks +0 lines, -8 lines 0 comments Download
M skia/ext/bitmap_platform_device.h View 1 chunk +0 lines, -2 lines 0 comments Download
D skia/ext/bitmap_platform_device_cairo.h View 1 chunk +0 lines, -130 lines 0 comments Download
D skia/ext/bitmap_platform_device_cairo.cc View 1 chunk +0 lines, -225 lines 0 comments Download
M skia/ext/platform_device.h View 2 chunks +1 line, -7 lines 0 comments Download
M ui/gfx/native_widget_types.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/sync_control_vsync_provider.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
5 years ago (2015-12-11 19:13:15 UTC) #1
jamesr
https://codereview.chromium.org/1518073002/diff/1/ui/gl/sync_control_vsync_provider.cc File ui/gl/sync_control_vsync_provider.cc (left): https://codereview.chromium.org/1518073002/diff/1/ui/gl/sync_control_vsync_provider.cc#oldcode128 ui/gl/sync_control_vsync_provider.cc:128: #if defined(USE_ASH) hm, wasn't USE_ASH true before? are you ...
5 years ago (2015-12-11 19:17:00 UTC) #2
viettrungluu
PTAL https://codereview.chromium.org/1518073002/diff/1/ui/gl/sync_control_vsync_provider.cc File ui/gl/sync_control_vsync_provider.cc (left): https://codereview.chromium.org/1518073002/diff/1/ui/gl/sync_control_vsync_provider.cc#oldcode128 ui/gl/sync_control_vsync_provider.cc:128: #if defined(USE_ASH) On 2015/12/11 19:17:00, jamesr wrote: > ...
5 years ago (2015-12-11 19:28:19 UTC) #3
jamesr
lgtm
5 years ago (2015-12-11 19:29:14 UTC) #4
viettrungluu
5 years ago (2015-12-11 20:02:02 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
053630c7f265d0870501f129ec32243113310c89 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698