Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1518013002: [turbofan] Add support for SOFT deopts and use that for property access. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for SOFT deopts and use that for property access. Up until now we were unable to (re)optimize code when we hit uninitialized (Keyed)Load/StoreICs in the code. We always put an IC there (sharing the feedback vector with fullcodegen at least) and called it a day. But we never deoptimized the code object when we gathered more feedback. This doesn't work very well in practice, esp. with hot code relying on this. So until we have a proper mechanism to express the need to reoptimize after we gathered additional feedback from optimized code, we follow the Crankshaft approach instead and install a SOFT deopt, so we can not only learn but also utilize the new feedback. R=mstarzinger@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/bda527b5ffd58b05ad6e6202c3d9b1632a20a4c8 Cr-Commit-Position: refs/heads/master@{#34178}

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : Simplification #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -20 lines) Patch
M src/compiler.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 2 4 chunks +65 lines, -10 lines 0 comments Download
M src/compiler/pipeline.cc View 1 1 chunk +10 lines, -5 lines 0 comments Download
M src/type-feedback-vector.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Benedikt Meurer
5 years ago (2015-12-11 14:03:11 UTC) #1
mvstanton
LGTM holds, as long as test fix isn't more than a couple lines :p
5 years ago (2015-12-11 14:26:03 UTC) #3
Michael Starzinger
LGTM.
5 years ago (2015-12-11 14:44:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518013002/40001
4 years, 10 months ago (2016-02-20 19:04:13 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-20 19:05:53 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-20 19:06:24 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bda527b5ffd58b05ad6e6202c3d9b1632a20a4c8
Cr-Commit-Position: refs/heads/master@{#34178}

Powered by Google App Engine
This is Rietveld 408576698