Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 1518003002: dart2js cps: Better GVN for fixed lengths and unmodified fields. (Closed)

Created:
5 years ago by asgerf
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Better GVN for fixed lengths and unmodified fields. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/a28639d634cfe8cc45d10d2c2696edec5e6a0651

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -10 lines) Patch
M pkg/compiler/lib/src/cps_ir/gvn.dart View 6 chunks +31 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
5 years ago (2015-12-11 14:25:23 UTC) #2
sra1
lgtm
5 years ago (2015-12-11 18:56:11 UTC) #3
asgerf
5 years ago (2015-12-14 11:46:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a28639d634cfe8cc45d10d2c2696edec5e6a0651 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698