third_party/WebKit/Source/core/html/HTMLPlugInElement.h - Issue 1517993004: Oilpan: simplify plugin container finalization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.h

Issue 1517993004: Oilpan: simplify plugin container finalization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: simplify away disconnectContentFrame override Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h

index afe27dc4c242ec9e98ae7c190e5b7283a30c9fe6..c77c088baf8629f039cd0e5ee488f35eafbe4201 100644

--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h

@@ -46,10 +46,6 @@ class CORE_EXPORT HTMLPlugInElement : public HTMLFrameOwnerElement {

public:

~HTMLPlugInElement() override;

DECLARE_VIRTUAL_TRACE();

-#if ENABLE(OILPAN)

- void disconnectContentFrame() override;

- void shouldDisposePlugin();

-#endif

void resetInstance();

SharedPersistent<v8::Object>* pluginWrapper();

@@ -137,12 +133,6 @@ private:

bool wouldLoadAsNetscapePlugin(const String& url, const String& serviceType);

void setPersistedPluginWidget(Widget*);

- PassRefPtrWillBeRawPtr<Widget> releasePersistedPluginWidget();

-#if ENABLE(OILPAN)

- bool unregisterAsRenderlessIfNeeded();

- void registerAsRenderless(Widget*);

-#endif

mutable RefPtr<SharedPersistent<v8::Object>> m_pluginWrapper;

NPObject* m_NPObject;