third_party/WebKit/Source/core/plugins/PluginView.h - Issue 1517993004: Oilpan: simplify plugin container finalization.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/plugins/PluginView.h

Issue 1517993004: Oilpan: simplify plugin container finalization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: simplify away disconnectContentFrame override Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Apple Inc. All rights reserved.	2 * Copyright (C) 2010 Apple Inc. All rights reserved.

3 * Copyright (C) 2013 Google Inc. All rights reserved.	3 * Copyright (C) 2013 Google Inc. All rights reserved.

4 * Copyright (C) 2014 Opera Software ASA. All rights reserved.	4 * Copyright (C) 2014 Opera Software ASA. All rights reserved.

5 *	5 *

6 * Redistribution and use in source and binary forms, with or without	6 * Redistribution and use in source and binary forms, with or without

7 * modification, are permitted provided that the following conditions	7 * modification, are permitted provided that the following conditions

8 * are met:	8 * are met:

9 * 1. Redistributions of source code must retain the above copyright	9 * 1. Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 39 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
50 virtual bool supportsKeyboardFocus() const { return false; }	50 virtual bool supportsKeyboardFocus() const { return false; }

51 virtual bool supportsInputMethod() const { return false; }	51 virtual bool supportsInputMethod() const { return false; }

52 virtual bool canProcessDrag() const { return false; }	52 virtual bool canProcessDrag() const { return false; }

53	53

54 virtual void didReceiveResponse(const ResourceResponse&) { }	54 virtual void didReceiveResponse(const ResourceResponse&) { }

55 virtual void didReceiveData(const char*, int) { }	55 virtual void didReceiveData(const char*, int) { }

56	56

57 virtual void layoutIfNeeded() { }	57 virtual void layoutIfNeeded() { }

58 virtual void invalidatePaintIfNeeded() { }	58 virtual void invalidatePaintIfNeeded() { }

59	59

60 #if ENABLE(OILPAN)

61 virtual LocalFrame* pluginFrame() const { return nullptr; }

62 virtual void shouldDisposePlugin() { }

63 #endif

64

65 protected:	60 protected:

66 PluginView() : Widget() { }	61 PluginView() : Widget() { }

67 };	62 };

68	63

69 DEFINE_TYPE_CASTS(PluginView, Widget, widget, widget->isPluginView(), widget.isP luginView());	64 DEFINE_TYPE_CASTS(PluginView, Widget, widget, widget->isPluginView(), widget.isP luginView());

70	65

71 } // namespace blink	66 } // namespace blink

72	67

73 #endif // PluginView_h	68 #endif // PluginView_h

OLD	NEW