Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1517983002: Map arm64 and mips64el -> x64 for mksnapshot (Closed)

Created:
5 years ago by agrieve
Modified:
5 years ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Map arm64 and mips64el -> x64 for mksnapshot BUG=chromium:568883 LOG=n Committed: https://crrev.com/ba1d9af8bf8d006846d2926c1661e51da141dc56 Cr-Commit-Position: refs/heads/master@{#32907}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M snapshot_toolchain.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
agrieve
Not actually sure this is correct (didn't try to run it, but fixed gn gen ...
5 years ago (2015-12-11 11:23:45 UTC) #2
jochen (gone - plz use gerrit)
On 2015/12/11 at 11:23:45, agrieve wrote: > Not actually sure this is correct (didn't try ...
5 years ago (2015-12-14 12:04:35 UTC) #3
agrieve
On 2015/12/14 12:04:35, jochen wrote: > On 2015/12/11 at 11:23:45, agrieve wrote: > > Not ...
5 years ago (2015-12-14 12:56:42 UTC) #5
jochen (gone - plz use gerrit)
i've updated the CL description some more :) now this lgtm
5 years ago (2015-12-16 08:39:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517983002/20001
5 years ago (2015-12-16 14:51:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-16 15:16:59 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-16 15:17:44 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba1d9af8bf8d006846d2926c1661e51da141dc56
Cr-Commit-Position: refs/heads/master@{#32907}

Powered by Google App Engine
This is Rietveld 408576698