[es6] support AssignmentPattern as LHS in for-in/of loops

[es6] support AssignmentPattern as LHS in for-in/of loops

BUG=v8:811, v8:4599
LOG=N
R=adamk@chromium.org, rossberg@chromium.org

Committed: https://crrev.com/18f41e46531ac0e1c6c9586a735795d842b627a0
Cr-Commit-Position: refs/heads/master@{#32814}

[caitp (gmail), 2015-12-11 11:16:10]

Description was changed from

==========
[es6] support AssignmentPattern as LHS in for-in/of loops

BUG=v8:811, v8:4599
LOG=N
R=bmeurer@chromium.org, adamk@chromium.org, rossberg@chromium.org
==========

to

==========
[es6] support AssignmentPattern as LHS in for-in/of loops

BUG=v8:811, v8:4599
LOG=N
R=adamk@chromium.org, rossberg@chromium.org
==========

[caitp (gmail), 2015-12-11 11:16:10]

caitpotter88@gmail.com changed reviewers:
- bmeurer@chromium.org

[caitp (gmail), 2015-12-11 11:16:27]

PTAL --- the fuzzer failure is fixed

[caitp (gmail), 2015-12-11 11:18:13]

Patchset #2 (id:20001) has been deleted

[caitp (gmail), 2015-12-11 11:19:36]

https://codereview.chromium.org/1517973002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1517973002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:3901: ValidateExpression(&classifier, CHECK_OK);
The problem was caused by the left-most expression not being validated as an
expression.

[caitp (gmail), 2015-12-11 16:52:41]

On 2015/12/11 11:19:36, caitp wrote:
> https://codereview.chromium.org/1517973002/diff/1/src/parsing/parser.cc
> File src/parsing/parser.cc (right):
> 
>
https://codereview.chromium.org/1517973002/diff/1/src/parsing/parser.cc#newco...
> src/parsing/parser.cc:3901: ValidateExpression(&classifier, CHECK_OK);
> The problem was caused by the left-most expression not being validated as an
> expression.

uploaded a version which puts all the classifier-validation logic in a single
place. It might be easier to understand that way

[adamk, 2015-12-11 18:37:01]

lgtm

[caitp (gmail), 2015-12-11 18:38:21]

The CQ bit was checked by caitpotter88@gmail.com

[commit-bot: I haz the power, 2015-12-11 18:38:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1517973002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1517973002/60001

[commit-bot: I haz the power, 2015-12-11 19:39:03]

Description was changed from

==========
[es6] support AssignmentPattern as LHS in for-in/of loops

BUG=v8:811, v8:4599
LOG=N
R=adamk@chromium.org, rossberg@chromium.org
==========

to

==========
[es6] support AssignmentPattern as LHS in for-in/of loops

BUG=v8:811, v8:4599
LOG=N
R=adamk@chromium.org, rossberg@chromium.org
==========

[commit-bot: I haz the power, 2015-12-11 19:39:03]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-12-11 19:39:48]

Description was changed from

==========
[es6] support AssignmentPattern as LHS in for-in/of loops

BUG=v8:811, v8:4599
LOG=N
R=adamk@chromium.org, rossberg@chromium.org
==========

to

==========
[es6] support AssignmentPattern as LHS in for-in/of loops

BUG=v8:811, v8:4599
LOG=N
R=adamk@chromium.org, rossberg@chromium.org

Committed: https://crrev.com/18f41e46531ac0e1c6c9586a735795d842b627a0
Cr-Commit-Position: refs/heads/master@{#32814}
==========

[commit-bot: I haz the power, 2015-12-11 19:39:51]

Patchset 3 (id:??) landed as
https://crrev.com/18f41e46531ac0e1c6c9586a735795d842b627a0
Cr-Commit-Position: refs/heads/master@{#32814}