Move Object.assign implementation to C++

Move Object.assign implementation to C++

This avoids a pair of super-high-degree polymorphic load/store ICs, and
creates the opportunity to add more fast paths if needed.

Committed: https://crrev.com/a83546932b4947e2c4e1e912f3fa50c8541dbb85
Cr-Commit-Position: refs/heads/master@{#32799}

[Jakob Kummerow, 2015-12-11 09:35:29]

jkummerow@chromium.org changed reviewers:
+ verwaest@chromium.org

[Toon Verwaest, 2015-12-11 10:06:07]

lgtm

https://codereview.chromium.org/1517963002/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1517963002/diff/1/src/builtins.cc#newcode1462
src/builtins.cc:1462: Object::ToObject(isolate, next_source));
This cannot fail anymore right?

https://codereview.chromium.org/1517963002/diff/1/test/mjsunit/harmony/proxie...
File test/mjsunit/harmony/proxies-object-assign.js (right):

https://codereview.chromium.org/1517963002/diff/1/test/mjsunit/harmony/proxie...
test/mjsunit/harmony/proxies-object-assign.js:23: assertEquals({"a": 1, "b": 1},
o);
Could you add a test for string sources just to make sure we don't break it?
That's the only interesting case for TO_OBJECT(source).

d8> o = {}
{}
d8> Object.assign(o, "bla")
{0: "b", 1: "l", 2: "a"}

[Jakob Kummerow, 2015-12-11 12:04:10]

https://codereview.chromium.org/1517963002/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1517963002/diff/1/src/builtins.cc#newcode1462
src/builtins.cc:1462: Object::ToObject(isolate, next_source));
On 2015/12/11 10:06:06, Toon Verwaest wrote:
> This cannot fail anymore right?

Done.

https://codereview.chromium.org/1517963002/diff/1/test/mjsunit/harmony/proxie...
File test/mjsunit/harmony/proxies-object-assign.js (right):

https://codereview.chromium.org/1517963002/diff/1/test/mjsunit/harmony/proxie...
test/mjsunit/harmony/proxies-object-assign.js:23: assertEquals({"a": 1, "b": 1},
o);
On 2015/12/11 10:06:07, Toon Verwaest wrote:
> Could you add a test for string sources just to make sure we don't break it?
> That's the only interesting case for TO_OBJECT(source).
> 
> d8> o = {}
> {}
> d8> Object.assign(o, "bla")
> {0: "b", 1: "l", 2: "a"}

Done.

[Jakob Kummerow, 2015-12-11 12:04:13]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2015-12-11 12:04:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1517963002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2015-12-11 12:04:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1517963002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1517963002/20001

[commit-bot: I haz the power, 2015-12-11 12:06:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-11 12:06:33]

Try jobs failed on following builders:
  v8_win_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/444)

[Jakob Kummerow, 2015-12-11 13:20:27]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2015-12-11 13:20:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1517963002/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2015-12-11 13:20:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1517963002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1517963002/40001

[commit-bot: I haz the power, 2015-12-11 14:10:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-11 14:11:03]

Description was changed from

==========
Move Object.assign implementation to C++

This avoids a pair of super-high-degree polymorphic load/store ICs, and
creates the opportunity to add more fast paths if needed.
==========

to

==========
Move Object.assign implementation to C++

This avoids a pair of super-high-degree polymorphic load/store ICs, and
creates the opportunity to add more fast paths if needed.

Committed: https://crrev.com/a83546932b4947e2c4e1e912f3fa50c8541dbb85
Cr-Commit-Position: refs/heads/master@{#32799}
==========

[commit-bot: I haz the power, 2015-12-11 14:11:03]

Patchset 3 (id:??) landed as
https://crrev.com/a83546932b4947e2c4e1e912f3fa50c8541dbb85
Cr-Commit-Position: refs/heads/master@{#32799}