Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1517933002: Revert of Removing references to webrtc::PortAllocatorFactoryInterface. (Closed)

Created:
5 years ago by Marijn Kruisselbrink
Modified:
5 years ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org, chromoting-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Removing references to webrtc::PortAllocatorFactoryInterface. (patchset #6 id:100001 of https://codereview.chromium.org/1500663003/ ) Reason for revert: Seems to break build at http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/97032/steps/compile/logs/stdio Original issue's description: > Removing references to webrtc::PortAllocatorFactoryInterface. > > Now using a new CreatePeerConnection method that takes a > PortAllocator as input. This removes the need for some > boilerplate code and code duplication between webrtc and chromium. > It also fixes an issue with TURN candidate priorities. > > BUG=webrtc:5209 > > Committed: https://crrev.com/ad868b5edf13e869e835b847078b4dcc8aa7cd0d > Cr-Commit-Position: refs/heads/master@{#364544} TBR=sergeyu@chromium.org,deadbeef@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5209

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -97 lines) Patch
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 2 chunks +87 lines, -22 lines 0 comments Download
M content/renderer/p2p/filtering_network_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/p2p/port_allocator.h View 3 chunks +47 lines, -0 lines 0 comments Download
M content/renderer/p2p/port_allocator.cc View 3 chunks +71 lines, -4 lines 0 comments Download
M remoting/host/cast_extension_session.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/cast_extension_session.cc View 4 chunks +15 lines, -14 lines 0 comments Download
M remoting/protocol/chromium_port_allocator.h View 1 chunk +4 lines, -1 line 0 comments Download
M remoting/protocol/chromium_port_allocator_factory.h View 2 chunks +8 lines, -6 lines 0 comments Download
M remoting/protocol/chromium_port_allocator_factory.cc View 1 chunk +20 lines, -4 lines 0 comments Download
D remoting/protocol/port_allocator_factory.h View 1 chunk +0 lines, -25 lines 0 comments Download
M remoting/protocol/webrtc_transport.h View 5 chunks +8 lines, -6 lines 0 comments Download
M remoting/protocol/webrtc_transport.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Marijn Kruisselbrink
5 years ago (2015-12-11 01:15:24 UTC) #1
Created Revert of Removing references to webrtc::PortAllocatorFactoryInterface.

Powered by Google App Engine
This is Rietveld 408576698