include/core/SkFlattenableBuffers.h - Issue 15179008: Add buffer helper to read directly into SkString to avoid extra copying

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkFlattenableBuffers.h

Issue 15179008: Add buffer helper to read directly into SkString to avoid extra copying (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: rebasing Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkFlattenableBuffers.h

diff --git a/include/core/SkFlattenableBuffers.h b/include/core/SkFlattenableBuffers.h

index f5b853c5ac478f6a0dac78563dd185ed5f1a9e5f..03c03f3877e6f8e3f508d29e371d5c7ebd91624e 100644

--- a/include/core/SkFlattenableBuffers.h

+++ b/include/core/SkFlattenableBuffers.h

@@ -60,7 +60,7 @@ public:

virtual int32_t read32() = 0;

// strings -- the caller is responsible for freeing the string contents

- virtual char* readString() = 0;

+ virtual void readString(SkString* string) = 0;

virtual void* readEncodedString(size_t* length, SkPaint::TextEncoding encoding) = 0;

// common data structures

« no previous file with comments | « no previous file | include/core/SkPaintOptionsAndroid.h » ('j') | no next file with comments »