src/core/SkPaintOptionsAndroid.cpp - Issue 15179008: Add buffer helper to read directly into SkString to avoid extra copying

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPaintOptionsAndroid.cpp

Issue 15179008: Add buffer helper to read directly into SkString to avoid extra copying (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkPaintOptionsAndroid.cpp

diff --git a/src/core/SkPaintOptionsAndroid.cpp b/src/core/SkPaintOptionsAndroid.cpp

index 7bf6fc44cd020ce269c865b10527625522b4a2dd..3b92f0a3fbc6840ebbf5175deb8ac05e775bcf9d 100644

--- a/src/core/SkPaintOptionsAndroid.cpp

+++ b/src/core/SkPaintOptionsAndroid.cpp

@@ -34,9 +34,9 @@ void SkPaintOptionsAndroid::flatten(SkFlattenableWriteBuffer& buffer) const {

void SkPaintOptionsAndroid::unflatten(SkFlattenableReadBuffer& buffer) {

fFontVariant = (FontVariant)buffer.readUInt();

- char* tag = buffer.readString();

+ SkString tag;

+ buffer.readString(tag);

fLanguage = SkLanguage(tag);

- sk_free(tag);

}

#endif