Issue 1517863002: Add translation of REV in ARM integrated assembler.

Issue 1517863002: Add translation of REV in ARM integrated assembler. (Closed)

Created:
5 years ago by Karl

Modified:
5 years ago

Reviewers:
Jim Stichnoth, sehr, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add translation of REV in ARM integrated assembler. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334 R=jpp@chromium.org, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7e87b6109c0d3c83ccb1c5bc7d334b43946ae085

Patch Set 2 : Reformat source. #

Total comments: 2

Patch Set 3 : Fix nit. #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -25 lines)			Patch
M	src/IceAssemblerARM32.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/IceAssemblerARM32.cpp	View	1 2	2 chunks	+21 lines, -0 lines	0 comments	Download
M	src/IceInstARM32.cpp	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
A +	tests_lit/assembler/arm32/rev.ll	View	1 2	2 chunks	+25 lines, -25 lines	0 comments	Download

Messages

Total messages: 9 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jim Stichnoth

lgtm https://codereview.chromium.org/1517863002/diff/20001/tests_lit/assembler/arm32/rev.ll File tests_lit/assembler/arm32/rev.ll (right): https://codereview.chromium.org/1517863002/diff/20001/tests_lit/assembler/arm32/rev.ll#newcode25 tests_lit/assembler/arm32/rev.ll:25: define internal i32 @_Z10test_rev(i32 %a) { Friendlier function ...

5 years ago (2015-12-11 16:51:23 UTC) #6

Karl

Committed patchset #3 (id:40001) manually as 7e87b6109c0d3c83ccb1c5bc7d334b43946ae085 (presubmit successful).

5 years ago (2015-12-11 17:32:32 UTC) #8

Karl

5 years ago (2015-12-11 17:32:41 UTC) #9

Message was sent while issue was closed.

https://codereview.chromium.org/1517863002/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/rev.ll (right):

https://codereview.chromium.org/1517863002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/rev.ll:25: define internal i32 @_Z10test_rev(i32 %a) {
On 2015/12/11 16:51:23, stichnot wrote:
> Friendlier function name?

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages