Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1517743003: Make ApplicationRunner's ctor's ApplicationDelegate* argument an std::unique_ptr instead. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make ApplicationRunner's ctor's ApplicationDelegate* argument an std::unique_ptr instead. And ditto for its delegate_ member. The lack of std::make_unique makes me very sad. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/755f46a99acb1d03db81d99b6108ddc07492f5cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -42 lines) Patch
M examples/apptest/example_service_application.cc View 2 chunks +5 lines, -1 line 0 comments Download
M examples/audio_play_test/play_tone.cc View 1 chunk +3 lines, -1 line 0 comments Download
M examples/audio_play_test/play_wav.cc View 1 chunk +3 lines, -1 line 0 comments Download
M examples/bank_app/bank.cc View 2 chunks +4 lines, -1 line 0 comments Download
M examples/bank_app/customer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M examples/content_handler_demo/content_handler_demo.cc View 2 chunks +5 lines, -1 line 0 comments Download
M examples/echo/echo_client.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M examples/echo/echo_server.cc View 2 chunks +4 lines, -1 line 0 comments Download
M examples/indirect_service/indirect_integer_service.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M examples/indirect_service/integer_service.cc View 2 chunks +5 lines, -1 line 0 comments Download
M examples/spinning_cube/spinning_cube_app.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M examples/wget/wget.cc View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/public/cpp/application/application_runner.h View 3 chunks +4 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/lib/application_runner.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 2 chunks +3 lines, -1 line 0 comments Download
M services/authentication/dummy_authentication_app.cc View 2 chunks +4 lines, -1 line 0 comments Download
M services/device_info/device_info.cc View 2 chunks +4 lines, -1 line 0 comments Download
M services/http_server/http_server_app.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M services/nacl/nonsfi/pnacl_compile.cc View 2 chunks +4 lines, -1 line 0 comments Download
M services/nacl/nonsfi/pnacl_link.cc View 2 chunks +4 lines, -1 line 0 comments Download
M services/test_service/test_request_tracker_application.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M services/test_service/test_service_application.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M shell/test/pingable_app.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
5 years ago (2015-12-10 20:27:13 UTC) #1
jamesr
maybe we should put a MakeUnique somewhere more visible. or just wait lgtm
5 years ago (2015-12-10 21:04:24 UTC) #2
viettrungluu
5 years ago (2015-12-10 21:16:36 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
755f46a99acb1d03db81d99b6108ddc07492f5cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698