Docserver: Properly implement the Cron logic for ContentProvider and TemplateDataSource so that the…

chrome/common/extensions/docs/server2/integration_test.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Run build_server so that files needed by tests are copied to the local
 # third_party directory.
 import build_server
 build_server.main()
 
 import json
 import optparse
 import os
 import posixpath
 import sys
 import time
 import unittest
 
 from branch_utility import BranchUtility
 from chroot_file_system import ChrootFileSystem
-from extensions_paths import EXTENSIONS, PUBLIC_TEMPLATES
+from extensions_paths import CONTENT_PROVIDERS, EXTENSIONS, PUBLIC_TEMPLATES
 from fake_fetchers import ConfigureFakeFetchers
+from third_party.json_schema_compiler import json_parse
 from handler import Handler
 from link_error_detector import LinkErrorDetector, StringifyBrokenLinks
 from local_file_system import LocalFileSystem
 from local_renderer import LocalRenderer
 from servlet import Request
-from test_util import EnableLogging, DisableLogging, ChromiumPath
+from test_util import ChromiumPath, DisableLogging, EnableLogging, ReadFile
+
 
 # Arguments set up if __main__ specifies them.
 _EXPLICIT_TEST_FILES = None
 _REBASE = False
 _VERBOSE = False
 
 
 def _ToPosixPath(os_path):
   return os_path.replace(os.sep, '/')
 
+
 def _GetPublicFiles():
-  '''Gets all public files mapped to their contents.
+  '''Gets all public file paths mapped to their contents.
   '''
-  public_path = ChromiumPath(PUBLIC_TEMPLATES)
+  def walk(path, prefix=''):
+    path = ChromiumPath(path)
+    public_files = {}
+    for root, dirs, files in os.walk(path, topdown=True):
+      relative_root = root[len(path):].lstrip(os.path.sep)
+      dirs[:] = [d for d in dirs if not d.startswith('.')]

[Yoyo Zhou, 2014/02/04 00:48:42]

Do you need to check if any of the path components start with . (because then
they will be hidden)? Or do you only care about . and ..?

[not at google - send to devlin, 2014/02/04 21:29:49]

These . checks are actually for hidden files. I'll make that clearer, and you're
right, this check is not quite right.

+      files[:] = [f for f in files if not f.startswith('.')]
+      for filename in files:
+        with open(os.path.join(root, filename), 'r') as f:
+          request_path = posixpath.join(prefix, relative_root, filename)
+          public_files[request_path] = f.read()
+    return public_files
+
+  # Public file locations are defined in content_providers.json, sort of.  Epic
+  # hack to pull them out; list all the files from the directories that
+  # Chromium content providers ask for.
   public_files = {}
-  for path, dirs, files in os.walk(public_path, topdown=True):
-    dirs[:] = [d for d in dirs if d != '.svn']
-    relative_posix_path = _ToPosixPath(path[len(public_path):])
-    for filename in files:
-      with open(os.path.join(path, filename), 'r') as f:
-        public_files['/'.join((relative_posix_path, filename))] = f.read()
+  content_providers = json_parse.Parse(ReadFile(CONTENT_PROVIDERS))
+  for content_provider in content_providers.itervalues():
+    if 'chromium' in content_provider:
+      public_files.update(walk(content_provider['chromium']['dir'],
+                               prefix=content_provider['serveFrom']))
   return public_files
 
+
 class IntegrationTest(unittest.TestCase):
   def setUp(self):
     ConfigureFakeFetchers()
 
   @EnableLogging('info')
   def testCronAndPublicFiles(self):
     '''Runs cron then requests every public file. Cron needs to be run first
     because the public file requests are offline.
     '''
     if _EXPLICIT_TEST_FILES is not None:
@@ skipping 54 matching lines @@
     #  for page in orphaned_pages:
     #    print(page)
     #print('Took %s seconds.' % (time.time() - start_time))
 
     public_files = _GetPublicFiles()
 
     print('Rendering %s public files...' % len(public_files.keys()))
     start_time = time.time()
     try:
       for path, content in public_files.iteritems():
-        assert path.startswith('/')
+        assert not path.startswith('/')
         if path.endswith('redirects.json'):
           continue
 
         def check_result(response):
           self.assertEqual(200, response.status,
               'Got %s when rendering %s' % (response.status, path))
           # This is reaaaaally rough since usually these will be tiny templates
           # that render large files. At least it'll catch zero-length responses.
           self.assertTrue(len(response.content) >= len(content),
-              'Content was "%s" when rendering %s' % (response.content, path))
+              'Rendered content length was %s vs template content length %s '
+              'when rendering %s' % (len(response.content), len(content), path))
 
         check_result(Handler(Request.ForTest(path)).Get())
 
-        # Make sure that leaving out the .html will temporarily redirect to the
-        # path with the .html.
-        if path.startswith(('/apps/', '/extensions/')):
-          redirect_result = Handler(
-              Request.ForTest(posixpath.splitext(path)[0])).Get()
-          self.assertEqual((path, False), redirect_result.GetRedirect())
+        if path.startswith(('apps/', 'extensions/')):
+          # Make sure that leaving out the .html will temporarily redirect to
+          # the path with the .html for APIs and articles.
+          if '/examples/' not in path:
+            base, _ = posixpath.splitext(path)
+            self.assertEqual(('/' + path, False),
+                             Handler(Request.ForTest(base)).Get().GetRedirect(),
+                             path)

[Yoyo Zhou, 2014/02/04 00:48:42]

If path is a message, it should have some ... message text.

[not at google - send to devlin, 2014/02/04 21:29:49]

Done.

 
-        # Make sure including a channel will permanently redirect to the same
-        # path without a channel.
-        for channel in BranchUtility.GetAllChannelNames():
-          redirect_result = Handler(
-              Request.ForTest('%s%s' % (channel, path))).Get()
-          self.assertEqual((path, True), redirect_result.GetRedirect())
+          # Make sure including a channel will permanently redirect to the same
+          # path without a channel.
+          for channel in BranchUtility.GetAllChannelNames():
+            redirect_result = Handler(
+                Request.ForTest(posixpath.join(channel, path))).Get()
+            self.assertEqual(('/' + path, True), redirect_result.GetRedirect())
 
         # Samples are internationalized, test some locales.
         if path.endswith('/samples.html'):
-          for lang in ['en-US', 'es', 'ar']:
+          for lang in ('en-US', 'es', 'ar'):
             check_result(Handler(Request.ForTest(
                 path,
                 headers={'Accept-Language': '%s;q=0.8' % lang})).Get())
     finally:
       print('Took %s seconds' % (time.time() - start_time))
 
     #if _REBASE:
     #  print('Rebasing broken links with %s newly broken and %s fixed links.' %
     #        (len(newly_broken_links), len(fixed_links)))
     #  with open(known_broken_links_path, 'w') as f:
@@ skipping 52 matching lines @@
   parser.add_option('-v', '--verbose', action='store_true', default=False,
                     help='Show verbose output like currently broken links')
   (opts, args) = parser.parse_args()
   if not opts.all:
     _EXPLICIT_TEST_FILES = args
   _REBASE = opts.rebase
   _VERBOSE = opts.verbose
   # Kill sys.argv because we have our own flags.
   sys.argv = [sys.argv[0]]
   unittest.main()