Server custom error severity support (#24452).

pkg/analysis_server/test/context_manager_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.context.directory.manager;
 
 import 'dart:collection';
 
 import 'package:analysis_server/src/context_manager.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/file_system/memory_file_system.dart';
 import 'package:analyzer/instrumentation/instrumentation.dart';
 import 'package:analyzer/source/embedder.dart';
+import 'package:analyzer/source/error_processor.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/error.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/generated/source_io.dart';
 import 'package:analyzer/src/services/lint.dart';
 import 'package:linter/src/plugin/linter_plugin.dart';
 import 'package:linter/src/rules/avoid_as.dart';
 import 'package:package_config/packages.dart';
 import 'package:path/path.dart';
 import 'package:plugin/manager.dart';
@@ skipping 57 matching lines @@
       new AnalysisError(new TestSource(), 0, 1, HintCode.INVALID_ASSIGNMENT, [
     ['x'],
     ['y']
   ]);
 
   AnalysisError unused_local_variable = new AnalysisError(
       new TestSource(), 0, 1, HintCode.UNUSED_LOCAL_VARIABLE, [
     ['x']
   ]);
 
-  List<ErrorFilter> get errorFilters =>
-      callbacks.currentContext.getConfigurationData(CONFIGURED_ERROR_FILTERS);
+  List<ErrorProcessor> get errorProcessors => callbacks.currentContext
+      .getConfigurationData(CONFIGURED_ERROR_PROCESSORS);
 
   List<Linter> get lints => getLints(callbacks.currentContext);
 
   AnalysisOptions get options => callbacks.currentContext.analysisOptions;
 
   void deleteFile(List<String> pathComponents) {
     String filePath = posix.joinAll(pathComponents);
     resourceProvider.deleteFile(filePath);
   }
 
+  ErrorProcessor getProcessor(AnalysisError error) =>
+      ErrorProcessor.getProcessor(callbacks.currentContext, error);
+
   String newFile(List<String> pathComponents, [String content = '']) {
     String filePath = posix.joinAll(pathComponents);
     resourceProvider.newFile(filePath, content);
     return filePath;
   }
 
   String newFolder(List<String> pathComponents) {
     String folderPath = posix.joinAll(pathComponents);
     resourceProvider.newFolder(folderPath);
     return folderPath;
@@ skipping 39 matching lines @@
 linter:
   rules:
     - camel_case_types
 ''');
 
     // Setup context.
     manager.setRoots(<String>[projPath], <String>[], <String, String>{});
     await pumpEventQueue();
 
     // Verify options were set.
-    expect(errorFilters, hasLength(1));
+    expect(errorProcessors, hasLength(1));
     expect(lints, hasLength(1));
     expect(options.enableGenericMethods, isTrue);
 
     // Remove options.
     deleteFile([projPath, AnalysisEngine.ANALYSIS_OPTIONS_FILE]);
     await pumpEventQueue();
 
     // Verify defaults restored.
-    expect(errorFilters, isEmpty);
+    expect(errorProcessors, isEmpty);
     expect(lints, isEmpty);
     expect(options.enableGenericMethods, isFalse);
   }
 
   test_analysis_options_file_delete_with_embedder() async {
     // Setup _embedder.yaml.
     String libPath = newFolder([projPath, LIB_NAME]);
     newFile(
         [libPath, '_embedder.yaml'],
         r'''
@@ skipping 26 matching lines @@
     - camel_case_types
 ''');
 
     // Setup context.
     manager.setRoots(<String>[projPath], <String>[], <String, String>{});
     await pumpEventQueue();
 
     // Verify options were set.
     expect(options.enableGenericMethods, isTrue);
     expect(options.strongMode, isTrue);
-    expect(errorFilters, hasLength(2));
+    expect(errorProcessors, hasLength(2));
     expect(lints, hasLength(2));
 
     // Remove options.
     deleteFile([projPath, AnalysisEngine.ANALYSIS_OPTIONS_FILE]);
     await pumpEventQueue();
 
     // Verify defaults restored.
     expect(options.enableGenericMethods, isFalse);
     expect(lints, hasLength(1));
     expect(lints.first, new isInstanceOf<AvoidAs>());
-    expect(errorFilters, hasLength(1));
-    expect(errorFilters.first(missing_return), isTrue);
+    expect(errorProcessors, hasLength(1));
+    expect(getProcessor(missing_return).severity, isNull);
   }
 
   test_analysis_options_parse_failure() async {
     // Create files.
     String libPath = newFolder([projPath, LIB_NAME]);
     newFile([libPath, 'main.dart']);
     String sdkExtPath = newFolder([projPath, 'sdk_ext']);
     newFile([sdkExtPath, 'entry.dart']);
     String sdkExtSrcPath = newFolder([projPath, 'sdk_ext', 'src']);
     newFile([sdkExtSrcPath, 'part.dart']);
@@ skipping 93 matching lines @@
     // * from `_embedder.yaml`:
     expect(context.analysisOptions.strongMode, isTrue);
     expect(context.analysisOptions.enableSuperMixins, isTrue);
     // * from `.analysis_options`:
     expect(context.analysisOptions.enableGenericMethods, isTrue);
     // * verify tests are excluded
     expect(callbacks.currentContextFilePaths[projPath].keys,
         ['/my/proj/sdk_ext/entry.dart']);
 
     // Verify filter setup.
-    expect(errorFilters, hasLength(2));
+    expect(errorProcessors, hasLength(2));
 
     // * (embedder.)
-    expect(errorFilters.any((f) => f(missing_return)), isTrue);
+    expect(getProcessor(missing_return).severity, isNull);
 
     // * (options.)
-    expect(errorFilters.any((f) => f(unused_local_variable)), isTrue);
+    expect(getProcessor(unused_local_variable).severity, isNull);
 
     // Verify lints.
     var lintNames = lints.map((lint) => lint.name);
 
     expect(
         lintNames,
         unorderedEquals(
             ['avoid_as' /* embedder */, 'camel_case_types' /* options */]));
 
     // Sanity check embedder libs.
@@ skipping 51 matching lines @@
         [projPath, AnalysisEngine.ANALYSIS_OPTIONS_FILE],
         r'''
 analyzer:
   errors:
     unused_local_variable: ignore
 ''');
     // Setup context.
     manager.setRoots(<String>[projPath], <String>[], <String, String>{});
 
     // Verify filter setup.
-    expect(errorFilters, isNotNull);
-    expect(errorFilters, hasLength(1));
-    expect(errorFilters.first(unused_local_variable), isTrue);
+    expect(errorProcessors, hasLength(1));
+    expect(getProcessor(unused_local_variable).severity, isNull);
   }
 
   test_error_filter_analysis_option_multiple_filters() async {
     // Create files.
     newFile(
         [projPath, AnalysisEngine.ANALYSIS_OPTIONS_FILE],
         r'''
 analyzer:
   errors:
     invalid_assignment: ignore
-    unused_local_variable: ignore
+    unused_local_variable: error
 ''');
     // Setup context.
     manager.setRoots(<String>[projPath], <String>[], <String, String>{});
 
     // Verify filter setup.
-    expect(errorFilters, isNotNull);
-    expect(errorFilters, hasLength(2));
+    expect(errorProcessors, hasLength(2));
 
-    expect(errorFilters.any((filter) => filter(unused_local_variable)), isTrue);
-    expect(
-        errorFilters.any((filter) => filter(invalid_assignment_error)), isTrue);
+    expect(getProcessor(invalid_assignment_error).severity, isNull);
+    expect(getProcessor(unused_local_variable).severity, ErrorSeverity.ERROR);
   }
 
   test_error_filter_analysis_option_synonyms() async {
     // Create files.
     newFile(
         [projPath, AnalysisEngine.ANALYSIS_OPTIONS_FILE],
         r'''
 analyzer:
   errors:
     unused_local_variable: ignore
     ambiguous_import: false
 ''');
     // Setup context.
     manager.setRoots(<String>[projPath], <String>[], <String, String>{});
 
     // Verify filter setup.
-    expect(errorFilters, isNotNull);
-    expect(errorFilters, hasLength(2));
+    expect(errorProcessors, isNotNull);
+    expect(errorProcessors, hasLength(2));
   }
 
   test_error_filter_analysis_option_unpsecified() async {
     // Create files.
     newFile(
         [projPath, AnalysisEngine.ANALYSIS_OPTIONS_FILE],
         r'''
 analyzer:
 #  errors:
 #    unused_local_variable: ignore
 ''');
     // Setup context.
     manager.setRoots(<String>[projPath], <String>[], <String, String>{});
 
     // Verify filter setup.
-    expect(errorFilters, isEmpty);
+    expect(errorProcessors, isEmpty);
   }
 
   test_ignoreFilesInPackagesFolder() {
     // create a context with a pubspec.yaml file
     String pubspecPath = posix.join(projPath, 'pubspec.yaml');
     resourceProvider.newFile(pubspecPath, 'pubspec');
     // create a file in the "packages" folder
     String filePath1 = posix.join(projPath, 'packages', 'file1.dart');
     resourceProvider.newFile(filePath1, 'contents');
     // "packages" files are ignored initially
@@ skipping 1924 matching lines @@
 class TestUriResolver extends UriResolver {
   Map<Uri, Source> uriMap;
 
   TestUriResolver(this.uriMap);
 
   @override
   Source resolveAbsolute(Uri uri, [Uri actualUri]) {
     return uriMap[uri];
   }
 }