Server custom error severity support (#24452).

Wraps up the server-side of the 'Allow a user to configure which hints are "fatal"' ask (#24452).

* migrates error filtering from a predicate to a process that can customize severities.
* moves filtering/processing from the `dart` task into the `getErrors` request and the errors notification.

See: https://github.com/dart-lang/sdk/issues/24452

(Pending a thumbs-up, support for CLI to follow.)

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/62656833d404361a474cad3acc9d50756a1472d4

[pquitslund, 2015-12-10 19:00:03]

Description was changed from

==========
Error processing support (WIP).

BUG=
==========

to

==========
Wraps up the server-side of the 'Allow a user to configure which hints are
"fatal"' ask (#24452). 

* migrates error filtering from a predicate to a process that can customize
severities.
* moves filtering/processing from the `dart` task into the `getErrors` request
and the errors notification.

See: https://github.com/dart-lang/sdk/issues/24452

(Pending a thumbs-up, support for CLI to follow.)
==========

[pquitslund, 2015-12-10 19:00:21]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-12-10 19:55:09]

LGTM

https://codereview.chromium.org/1517723002/diff/100001/pkg/analyzer/lib/sourc...
File pkg/analyzer/lib/source/error_processor.dart (right):

https://codereview.chromium.org/1517723002/diff/100001/pkg/analyzer/lib/sourc...
pkg/analyzer/lib/source/error_processor.dart:5: library source.error_processor;
nit: I think the library name is suppose to be prefixed with "analyzer.".

https://codereview.chromium.org/1517723002/diff/100001/pkg/analyzer/test/sour...
File pkg/analyzer/test/source/error_processor_test.dart (right):

https://codereview.chromium.org/1517723002/diff/100001/pkg/analyzer/test/sour...
pkg/analyzer/test/source/error_processor_test.dart:5: library
test.source.error_processor;
nit: "analyzer.test.source.error_processor_test"

[pquitslund, 2015-12-10 21:34:31]

Thanks!

https://codereview.chromium.org/1517723002/diff/100001/pkg/analyzer/lib/sourc...
File pkg/analyzer/lib/source/error_processor.dart (right):

https://codereview.chromium.org/1517723002/diff/100001/pkg/analyzer/lib/sourc...
pkg/analyzer/lib/source/error_processor.dart:5: library source.error_processor;
On 2015/12/10 19:55:09, Brian Wilkerson wrote:
> nit: I think the library name is suppose to be prefixed with "analyzer.".

Absolutely.  I was aiming to stay consistent with the libraries around it, which
have changed since I started this CL! :)

Fixed now.

https://codereview.chromium.org/1517723002/diff/100001/pkg/analyzer/test/sour...
File pkg/analyzer/test/source/error_processor_test.dart (right):

https://codereview.chromium.org/1517723002/diff/100001/pkg/analyzer/test/sour...
pkg/analyzer/test/source/error_processor_test.dart:5: library
test.source.error_processor;
On 2015/12/10 19:55:09, Brian Wilkerson wrote:
> nit: "analyzer.test.source.error_processor_test"

Done.

[pquitslund, 2015-12-10 21:35:14]

Description was changed from

==========
Wraps up the server-side of the 'Allow a user to configure which hints are
"fatal"' ask (#24452). 

* migrates error filtering from a predicate to a process that can customize
severities.
* moves filtering/processing from the `dart` task into the `getErrors` request
and the errors notification.

See: https://github.com/dart-lang/sdk/issues/24452

(Pending a thumbs-up, support for CLI to follow.)
==========

to

==========
Wraps up the server-side of the 'Allow a user to configure which hints are
"fatal"' ask (#24452).

* migrates error filtering from a predicate to a process that can customize
severities.
* moves filtering/processing from the `dart` task into the `getErrors` request
and the errors notification.

See: https://github.com/dart-lang/sdk/issues/24452

(Pending a thumbs-up, support for CLI to follow.)

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/62656833d404361a474cad3acc9d50756a1472d4
==========

[pquitslund, 2015-12-10 21:35:16]

Committed patchset #7 (id:120001) manually as
62656833d404361a474cad3acc9d50756a1472d4 (presubmit successful).